Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/238641
Change subject: MWWelcomeDialog: Split text, tweak styling
......................................................................
MWWelcomeDialog: Split text, tweak styling
Change-Id: If15dc9fe4a01e81cf7d85e2670878bbd5899f068
---
M extension.json
M modules/ve-mw/ui/dialogs/ve.ui.MWWelcomeDialog.js
M modules/ve-mw/ui/styles/dialogs/ve.ui.MWWelcomeDialog.css
M modules/ve-wmf/i18n/en.json
M modules/ve-wmf/i18n/qqq.json
5 files changed, 17 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/41/238641/1
diff --git a/extension.json b/extension.json
index 881f408..71b4452 100644
--- a/extension.json
+++ b/extension.json
@@ -1045,6 +1045,7 @@
"visualeditor-viewpage-savewarning-title",
"visualeditor-welcomedialog-action",
"visualeditor-welcomedialog-content",
+ "visualeditor-welcomedialog-content-thanks",
"visualeditor-welcomedialog-title",
"visualeditor-wikitext-progress",
"visualeditor-wikitext-warning-title",
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWWelcomeDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWWelcomeDialog.js
index 452c7a4..772a895 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWWelcomeDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWWelcomeDialog.js
@@ -48,7 +48,12 @@
data = $.extend( {
title: ve.msg( 'visualeditor-welcomedialog-title', mw.user,
mw.config.get( 'wgSiteName' ) ),
message: $( '<div>' ).addClass(
'visualeditor-welcomedialog-content' )
- .append( ve.msg( 'visualeditor-welcomedialog-content' )
)
+ .append( $( '<span>' ) ).addClass(
'visualeditor-welcomedialog-content-text' )
+ .text(
+ ve.msg( 'visualeditor-welcomedialog-content' ) +
+ '<br />' +
+ ve.msg(
'visualeditor-welcomedialog-content-thanks' )
+ )
}, data );
return ve.ui.MWWelcomeDialog.super.prototype.getSetupProcess.call(
this, data );
diff --git a/modules/ve-mw/ui/styles/dialogs/ve.ui.MWWelcomeDialog.css
b/modules/ve-mw/ui/styles/dialogs/ve.ui.MWWelcomeDialog.css
index e54ed39..2708314 100644
--- a/modules/ve-mw/ui/styles/dialogs/ve.ui.MWWelcomeDialog.css
+++ b/modules/ve-mw/ui/styles/dialogs/ve.ui.MWWelcomeDialog.css
@@ -5,8 +5,13 @@
* @license The MIT License (MIT); see LICENSE.txt
*/
.visualeditor-welcomedialog-content {
- margin-top: 1em;
background: url(images/welcomeSplash-ltr.png) 50% 100% no-repeat;
- background-size: 35%;
+ background-size: 50%;
height: 200px;
+ text-align: center;
+}
+
+.visualeditor-welcomedialog-content-text {
+ display: inline-block;
+ margin-top: 12em;
}
diff --git a/modules/ve-wmf/i18n/en.json b/modules/ve-wmf/i18n/en.json
index a00c2e7..5a4a8a4 100644
--- a/modules/ve-wmf/i18n/en.json
+++ b/modules/ve-wmf/i18n/en.json
@@ -28,6 +28,7 @@
"visualeditor-help-link":
"mw:Special:MyLanguage\/Help:VisualEditor\/User guide",
"visualeditor-help-title": "Guide for how to use the editor",
"visualeditor-welcomedialog-action": "Start editing",
- "visualeditor-welcomedialog-content": "Anyone can edit, and every
improvement helps. Thank you for helping the world discover more!",
+ "visualeditor-welcomedialog-content": "Anyone can edit, and every
improvement helps.",
+ "visualeditor-welcomedialog-content-thanks": "Thank you for helping the
world discover more!",
"visualeditor-welcomedialog-title": "{{GENDER:$1|Welcome}} to $2"
}
diff --git a/modules/ve-wmf/i18n/qqq.json b/modules/ve-wmf/i18n/qqq.json
index e275de6..d0415b5 100644
--- a/modules/ve-wmf/i18n/qqq.json
+++ b/modules/ve-wmf/i18n/qqq.json
@@ -33,5 +33,6 @@
"visualeditor-help-title": "Title (hover) text for the link to the user
guide",
"visualeditor-welcomedialog-action": "Label for the 'Start editing'
button used to close the welcome dialog and start using the
editor.\n{{Identical|Start editing}}",
"visualeditor-welcomedialog-content": "Text welcoming the user to
editing.",
+ "visualeditor-welcomedialog-content-thanks": "Text thanking the user
for any edits they might make.",
"visualeditor-welcomedialog-title": "Title of the welcome dialog.
Parameters:\n* $1 - username or empty string, for GENDER support\n* $2 - value
of the SITENAME parser function."
}
--
To view, visit https://gerrit.wikimedia.org/r/238641
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If15dc9fe4a01e81cf7d85e2670878bbd5899f068
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
