jenkins-bot has submitted this change and it was merged.
Change subject: Position the banner when banner is cached
......................................................................
Position the banner when banner is cached
The load event may have already fired when this code has run to ensure we run
twice
for the cached instance.
Change-Id: I3cd7566edbb630f18beff2d3c1a4512a05cea5ca
---
M
resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
1 file changed, 8 insertions(+), 2 deletions(-)
Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
index 4354935..7c7ed0e 100644
---
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
+++
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
@@ -1,5 +1,7 @@
( function( mw, $ ) {
- var $wpbBannerImageContainer = $( '.wpb-topbanner' );
+ var $wpbBannerImageContainer = $( '.wpb-topbanner' ),
+ $img = $( 'img.wpb-banner-image' );
+
function positionBanner( $container ) {
/**
* Javascript to fine tune position of banner according to
position coordinates.
@@ -69,9 +71,13 @@
}
) );
// set focus after image has loaded
- $( 'img.wpb-banner-image' ).load( function() {
+ $img.load( function() {
positionBanner( $wpbBannerImageContainer );
} );
+ // Image might be cached
+ if ( $img.length && $img[0].complete ) {
+ positionBanner( $wpbBannerImageContainer );
+ }
// Expose interface for testing.
mw.wpb = {
positionBanner: positionBanner
--
To view, visit https://gerrit.wikimedia.org/r/238653
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cd7566edbb630f18beff2d3c1a4512a05cea5ca
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Bene <benestar.wikime...@gmail.com>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Kaldari <rkald...@wikimedia.org>
Gerrit-Reviewer: Sumit <asthana.sumi...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
