[MediaWiki-commits] [Gerrit] Use English wiki site to work around test failure - change (apps...wikipedia)

[Niedzielski (Code Review)]

Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/238795

Change subject: Use English wiki site to work around test failure
......................................................................

Use English wiki site to work around test failure

Change-Id: Iacd9827a3409f8c918e77393d244d828563c3ba9
---
M app/src/androidTest/java/org/wikipedia/test/FullSearchTaskTests.java
1 file changed, 10 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/95/238795/1

diff --git 
a/app/src/androidTest/java/org/wikipedia/test/FullSearchTaskTests.java 
b/app/src/androidTest/java/org/wikipedia/test/FullSearchTaskTests.java
index 3b983dd..0ecce6e 100644
--- a/app/src/androidTest/java/org/wikipedia/test/FullSearchTaskTests.java
+++ b/app/src/androidTest/java/org/wikipedia/test/FullSearchTaskTests.java
@@ -5,6 +5,7 @@
 import org.wikipedia.WikipediaApp;
 import org.wikipedia.search.FullSearchArticlesTask;
 import org.wikipedia.search.SearchResults;
+import org.wikipedia.util.log.L;
 
 import android.content.Intent;
 import android.test.ActivityUnitTestCase;
@@ -17,8 +18,7 @@
 public class FullSearchTaskTests extends 
ActivityUnitTestCase<TestDummyActivity> {
     private static final int TASK_COMPLETION_TIMEOUT = 20000;
     private static final int BATCH_SIZE = 12;
-    private static final Site SITE = new Site("test.wikipedia.org");
-    private static final Site EN_SITE = new Site("en.wikipedia.org");
+    private static final Site SITE = new Site("en.wikipedia.org");
 
     public FullSearchTaskTests() {
         super(TestDummyActivity.class);
@@ -32,7 +32,7 @@
             @Override
             public void run() {
                 final WikipediaApp app = (WikipediaApp) 
getInstrumentation().getTargetContext().getApplicationContext();
-                new FullSearchArticlesTask(app.getAPIForSite(EN_SITE), 
EN_SITE, "test", BATCH_SIZE, null, false) {
+                new FullSearchArticlesTask(app.getAPIForSite(SITE), SITE, 
"test", BATCH_SIZE, null, false) {
                     @Override
                     public void onFinish(SearchResults results) {
                         assertNotNull(results);
@@ -85,12 +85,19 @@
                 new FullSearchArticlesTask(app.getAPIForSite(SITE), SITE, 
"jkfsdfpefdsfwoirpoik", BATCH_SIZE, null, false) { // total gibberish, should 
not exist on testwiki
                     @Override
                     public void onFinish(SearchResults results) {
+                        L.d("success");
                         assertNotNull(results);
                         assertEquals(results.getPageTitles().size(), 0);
                         assertEquals(results.getSuggestion(), "");
                         assertNull(results.getContinueOffset());
                         completionLatch.countDown();
                     }
+
+                    @Override
+                    public void onCatch(Throwable caught) {
+                        L.d("fail" + caught);
+                        super.onCatch(caught);
+                    }
                 }.execute();
             }
         });

-- 
To view, visit https://gerrit.wikimedia.org/r/238795
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iacd9827a3409f8c918e77393d244d828563c3ba9
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits