Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/238806
Change subject: MW*LinkAnnotation: Fix class names
......................................................................
MW*LinkAnnotation: Fix class names
Link annotations now use $anchor instead of $element for the main <a> tag.
Change-Id: I038ecf97133a71fe86bb0d269a64bbe0ba46bdc2
---
M modules/ve-mw/ce/annotations/ve.ce.MWExternalLinkAnnotation.js
M modules/ve-mw/ce/annotations/ve.ce.MWInternalLinkAnnotation.js
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/06/238806/1
diff --git a/modules/ve-mw/ce/annotations/ve.ce.MWExternalLinkAnnotation.js
b/modules/ve-mw/ce/annotations/ve.ce.MWExternalLinkAnnotation.js
index efb1075..56f171c 100644
--- a/modules/ve-mw/ce/annotations/ve.ce.MWExternalLinkAnnotation.js
+++ b/modules/ve-mw/ce/annotations/ve.ce.MWExternalLinkAnnotation.js
@@ -20,7 +20,7 @@
ve.ce.MWExternalLinkAnnotation.super.apply( this, arguments );
// DOM changes
- this.$element.addClass( 'external' );
+ this.$anchor.addClass( 'external' );
};
/* Inheritance */
diff --git a/modules/ve-mw/ce/annotations/ve.ce.MWInternalLinkAnnotation.js
b/modules/ve-mw/ce/annotations/ve.ce.MWInternalLinkAnnotation.js
index c8f0450..801e06e 100644
--- a/modules/ve-mw/ce/annotations/ve.ce.MWInternalLinkAnnotation.js
+++ b/modules/ve-mw/ce/annotations/ve.ce.MWInternalLinkAnnotation.js
@@ -21,10 +21,10 @@
ve.ce.MWInternalLinkAnnotation.super.apply( this, arguments );
// DOM changes
- this.$element.addClass( 've-ce-mwInternalLinkAnnotation' );
+ this.$anchor.addClass( 've-ce-mwInternalLinkAnnotation' );
// Style based on link cache information
- ve.init.platform.linkCache.styleElement( this.model.getAttribute(
'lookupTitle' ), annotation.$element );
+ ve.init.platform.linkCache.styleElement( this.model.getAttribute(
'lookupTitle' ), annotation.$anchor );
};
/* Inheritance */
--
To view, visit https://gerrit.wikimedia.org/r/238806
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I038ecf97133a71fe86bb0d269a64bbe0ba46bdc2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
