AndyRussG has uploaded a new change for review.
https://gerrit.wikimedia.org/r/238820
Change subject: bannerHistoryLogger.sendLog: use the promise from logEvent
......................................................................
bannerHistoryLogger.sendLog: use the promise from logEvent
Bug: T112022
Change-Id: I0b68e10d217594abcf3be27ca38f544938113db9
---
M resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/20/238820/1
diff --git a/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
b/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
index f8d6c38..9ca1b29 100644
--- a/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
+++ b/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
@@ -289,7 +289,7 @@
var deferred = $.Deferred();
- // With luck, this promise will be resoved by the time
we get here
+ // With luck, this promise will be resolved by the time
we get here
readyToLogPromise.done( function() {
var logId = mw.user.generateRandomSessionId();
@@ -297,9 +297,9 @@
mw.eventLog.logEvent(
EVENT_LOGGING_SCHEMA,
makeEventLoggingData( null, logId )
- );
-
- deferred.resolve( logId );
+ ).always( function() {
+ deferred.resolve( logId );
+ } );
} );
return deferred.promise();
--
To view, visit https://gerrit.wikimedia.org/r/238820
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b68e10d217594abcf3be27ca38f544938113db9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: AndyRussG <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
