Chad has uploaded a new change for review.
https://gerrit.wikimedia.org/r/238828
Change subject: Avoid race condition where lock file disappeared from under us
......................................................................
Avoid race condition where lock file disappeared from under us
Change-Id: I26c87c22cefc3a12a195e3c705c3ba945ae8aa23
---
M scap/utils.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/scap
refs/changes/28/238828/1
diff --git a/scap/utils.py b/scap/utils.py
index 5367ec2..cf03eb1 100644
--- a/scap/utils.py
+++ b/scap/utils.py
@@ -276,7 +276,8 @@
if lock_fd:
fcntl.lockf(lock_fd, fcntl.LOCK_UN)
lock_fd.close()
- os.unlink(filename)
+ if os.path.exists(filename):
+ os.unlink(filename)
@contextlib.contextmanager
--
To view, visit https://gerrit.wikimedia.org/r/238828
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26c87c22cefc3a12a195e3c705c3ba945ae8aa23
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/scap
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
