Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/238955
Change subject: Fix link preview button color on pre-21 devices
......................................................................
Fix link preview button color on pre-21 devices
ripple_material_light is too light on Lollipop so a darker color is specified.
This patch simply sets that color for API 21 only.
Bug: T109875
Change-Id: I8cb3818cf52f6512714d5bfe7a2971989060caf9
---
A app/src/main/res/values-v21/colors.xml
M app/src/main/res/values/colors.xml
M app/src/main/res/values/styles.xml
3 files changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/55/238955/1
diff --git a/app/src/main/res/values-v21/colors.xml
b/app/src/main/res/values-v21/colors.xml
new file mode 100644
index 0000000..0cb652a
--- /dev/null
+++ b/app/src/main/res/values-v21/colors.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+ <color
name="link_preview_button_background_highlight">@color/actionbar_highlight</color>
+</resources>
\ No newline at end of file
diff --git a/app/src/main/res/values/colors.xml
b/app/src/main/res/values/colors.xml
index c7488ce..e88170c 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -53,6 +53,7 @@
<color name="link_preview_toolbar_light">#404040</color>
<color name="link_preview_background_light">#f0f0f0</color>
<color name="link_preview_text_light">#505050</color>
+ <color
name="link_preview_button_background_highlight">@color/ripple_material_light</color>
<color name="link_dark">#ff2B6FB2</color>
<color name="button_dark">#ff2B6FB2</color>
diff --git a/app/src/main/res/values/styles.xml
b/app/src/main/res/values/styles.xml
index 9733058..64f028b 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -134,8 +134,8 @@
<item name="android:backgroundDimAmount">0.5</item>
<item name="android:colorControlNormal">@android:color/white</item>
<item name="colorControlNormal">@android:color/white</item>
- <item name="colorControlActivated">@color/actionbar_highlight</item>
- <item name="colorControlHighlight">@color/actionbar_highlight</item>
+ <item
name="colorControlActivated">@color/link_preview_button_background_highlight</item>
+ <item
name="colorControlHighlight">@color/link_preview_button_background_highlight</item>
</style>
<!-- Default style for floating action buttons -->
--
To view, visit https://gerrit.wikimedia.org/r/238955
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cb3818cf52f6512714d5bfe7a2971989060caf9
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
