Paladox has uploaded a new change for review.
https://gerrit.wikimedia.org/r/239120
Change subject: Fix jslint errors
......................................................................
Fix jslint errors
Ignores files we carnt edit directly due to copied files from other
places.
Change-Id: I39967507230112977d54cae3b866160b3a52da7b
---
A .jshintignore
M scripts/OfflineImportLexicon.js
2 files changed, 7 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OfflineImportLexicon
refs/changes/20/239120/1
diff --git a/.jshintignore b/.jshintignore
new file mode 100644
index 0000000..2be6951
--- /dev/null
+++ b/.jshintignore
@@ -0,0 +1,3 @@
+/* Ignore js files we carnt edit direct */
+scripts/jquery.ezpz_tooltip.js
+scripts/jquery.ezpz_tooltip.min.js
diff --git a/scripts/OfflineImportLexicon.js b/scripts/OfflineImportLexicon.js
index f5a343a..6f073e9 100644
--- a/scripts/OfflineImportLexicon.js
+++ b/scripts/OfflineImportLexicon.js
@@ -89,7 +89,7 @@
// Retrieve lexicons when application starts
jQuery(document).ready(function() {
// init status bar
- var status = "Click on New Lexicon ..."
+ var status = "Click on New Lexicon ...";
_statusbar = new StatusBar(null,{showCloseButton:
true,additive:true,afterTimeoutText: status });
_statusbar.show(status);
var query = wgServer+wgScript+jsonGeneralLink+jsonLink;
@@ -98,12 +98,12 @@
jQuery("#selectLexicon").change(function (event) {
jQuery("#lexiconList li").remove();
- if(jQuery("#selectLexicon option:selected").val()!="" ||
jQuery("#selectLexicon option:selected").val()!=undefined)
+ if(jQuery("#selectLexicon option:selected").val()!=="" ||
jQuery("#selectLexicon option:selected").val()!==undefined)
{
jQuery("#selectVolume option").remove();
var temp = trim(jQuery("#selectLexicon
option:selected").attr('title'));
var query = wgServer+wgScript+jsonGeneralLink;
- if(temp!="")
+ if(temp!=="")
{
query += jsonLinkVolume.replace('@@@',jQuery("#selectLexicon
option:selected").val().replace(/-/g,'-2D').replace(/ /g,'-20'));
getJsonProperties('volume', query);
@@ -120,7 +120,7 @@
jQuery("#selectVolume").change(function (event) {
jQuery("#lexiconList li").remove();
- if(jQuery("#selectVolume option:selected").val()!="" ||
jQuery("#selectVolume option:selected").val()!=undefined)
+ if(jQuery("#selectVolume option:selected").val()!=="" ||
jQuery("#selectVolume option:selected").val()!==undefined)
{
var temp = trim(jQuery("#selectVolume option:selected").text());
var lexicon = trim(jQuery("#selectLexicon option:selected").text());
--
To view, visit https://gerrit.wikimedia.org/r/239120
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39967507230112977d54cae3b866160b3a52da7b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OfflineImportLexicon
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
