jenkins-bot has submitted this change and it was merged.

Change subject: Don't force 100% width
......................................................................


Don't force 100% width

Images with nearly the same width as height would be really really big,
which would look terrible, instead of providing a real feature.

Remove the 100% and use it as a max-width (so images doesn't overflow the
border of the panel). Use a maxheight of 18em for the image to scale.

Change-Id: I3f7c669a49921d3cd528f0b7457eb310dd674942
---
M resources/ext.QuickSearchLookup/ext.QuickSearchLookup.css
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Florianschmidtwelzow: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/ext.QuickSearchLookup/ext.QuickSearchLookup.css 
b/resources/ext.QuickSearchLookup/ext.QuickSearchLookup.css
index 0c44592..738109b 100644
--- a/resources/ext.QuickSearchLookup/ext.QuickSearchLookup.css
+++ b/resources/ext.QuickSearchLookup/ext.QuickSearchLookup.css
@@ -16,7 +16,8 @@
 }
 
 .mw-search-quicklookup-image-cross {
-       width: 100%;
+       max-width: 100%;
+       max-height: 18em;
        height: auto;
        margin-bottom: 1em;
        clear: both;

-- 
To view, visit https://gerrit.wikimedia.org/r/237053
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f7c669a49921d3cd528f0b7457eb310dd674942
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/QuickSearchLookup
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to