MarkAHershberger has uploaded a new change for review.
https://gerrit.wikimedia.org/r/239579
Change subject: Introduce createJobsFromRequest
......................................................................
Introduce createJobsFromRequest
I anticipate a need to have job insertion separated from job creation
Change-Id: Ib15bf5a0108db8c00f021e5c566408d86f453415
---
M SpecialReplaceText.php
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ReplaceText
refs/changes/79/239579/1
diff --git a/SpecialReplaceText.php b/SpecialReplaceText.php
index 2927ad2..aab977f 100644
--- a/SpecialReplaceText.php
+++ b/SpecialReplaceText.php
@@ -40,7 +40,7 @@
return $selectedNamespaces;
}
- protected function insertReplaceTextJob( $request ) {
+ protected function createJobsFromRequest( $request ) {
$replacementParams = array();
$replacementParams['user_id'] = $this->getUser()->getId();
$replacementParams['target_str'] = $this->target;
@@ -77,7 +77,10 @@
);
}
}
+ return $jobs;
+ }
+ protected function insertReplaceTextJob( $jobs ) {
// BC for 1.20 and lower
if ( class_exists( 'JobQueueGroup' ) ) {
JobQueueGroup::singleton()->push( $jobs );
@@ -303,7 +306,9 @@
if ( $request->getCheck( 'replace' ) ) {
wfProfileOut( __METHOD__ );
- return $this->insertReplaceTextJob( $request );
+ return $this->insertReplaceTextJob(
+ $this->createJobsFromRequest( $request )
+ );
} elseif ( $request->getCheck( 'target' ) ) {
wfProfileOut( __METHOD__ );
return $this->showConfirmationForm();
--
To view, visit https://gerrit.wikimedia.org/r/239579
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib15bf5a0108db8c00f021e5c566408d86f453415
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ReplaceText
Gerrit-Branch: master
Gerrit-Owner: MarkAHershberger <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
