jenkins-bot has submitted this change and it was merged.
Change subject: Using mw.config.get/set to access JavaScript vars
......................................................................
Using mw.config.get/set to access JavaScript vars
Accessing global JavaScript variables directly has long been deprecated.
This patch adds the usage of 'mw.config.get/set'.
Patch Set 2:
Removed unused CSS classes that were uncovered by jenkins
Change-Id: Ia2777956a02a96b321781027ea4a07fa888d466f
---
M resources/bluespice.extjs/bluespice.extjs.BS.portal.css
M resources/bluespice/bluespice.ping.js
2 files changed, 1 insertion(+), 10 deletions(-)
Approvals:
Robert Vogel: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/bluespice.extjs/bluespice.extjs.BS.portal.css
b/resources/bluespice.extjs/bluespice.extjs.BS.portal.css
index e801bf6..d94bb14 100644
--- a/resources/bluespice.extjs/bluespice.extjs.BS.portal.css
+++ b/resources/bluespice.extjs/bluespice.extjs.BS.portal.css
@@ -57,12 +57,3 @@
padding: 5px;
font-size: 12px;
}
-.settings {
- background-image:url(../shared/icons/fam/folder_wrench.png);
-}
-.nav {
- background-image:url(../shared/icons/fam/folder_go.png);
-}
-.info {
- background-image:url(../shared/icons/fam/information.png);
-}
diff --git a/resources/bluespice/bluespice.ping.js
b/resources/bluespice/bluespice.ping.js
index fefa0bd..1f38397 100644
--- a/resources/bluespice/bluespice.ping.js
+++ b/resources/bluespice/bluespice.ping.js
@@ -4,7 +4,7 @@
init: function() {
$(document).triggerHandler('BSPingInit', [BSPing]);
- BSPing.interval = bsPingInterval*1000;
+ BSPing.interval = mw.config.get( 'bsPingInterval' ) * 1000;
if ( BSPing.interval < 1000 ) return;
BSPing.ping();
--
To view, visit https://gerrit.wikimedia.org/r/239030
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2777956a02a96b321781027ea4a07fa888d466f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation
Gerrit-Branch: master
Gerrit-Owner: Robert Vogel <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Pwirth <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: Tweichart <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
