jenkins-bot has submitted this change and it was merged.
Change subject: jsduck: Load OOjs and OOjs UI in eg-iframe.html
......................................................................
jsduck: Load OOjs and OOjs UI in eg-iframe.html
This makes live preview work for OOUI classes.
Also:
* Remove duplicate definition of window.onerror (the latter which
fails to include the 'error' variable in the logged message).
* Set mwPerformance to match startup.js as it was throwing
a fatal exception on every page.
Bug: T112116
Change-Id: I00e789a2853e82e9a89d07752ce92fa6bb9615f5
---
M maintenance/jsduck/eg-iframe.html
1 file changed, 13 insertions(+), 4 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/jsduck/eg-iframe.html
b/maintenance/jsduck/eg-iframe.html
index 2c42364..5434735 100644
--- a/maintenance/jsduck/eg-iframe.html
+++ b/maintenance/jsduck/eg-iframe.html
@@ -34,6 +34,9 @@
};
</script>
<script>
+ // Emulate startup.js
+ var mwPerformance = { mark: function () {} };
+
function startUp() {
mw.config = new mw.Map();
}
@@ -43,7 +46,15 @@
<script src="modules/src/mediawiki/mediawiki.js"></script>
<script src="modules/src/mediawiki/mediawiki.errorLogger.js"></script>
<script src="modules/src/mediawiki/mediawiki.startUp.js"></script>
+ <script src="modules/lib/oojs/oojs.jquery.js"></script>
+ <script src="modules/lib/oojs-ui/oojs-ui.js"></script>
+ <script src="modules/lib/oojs-ui/oojs-ui-mediawiki.js"></script>
<style>
+ body {
+ font-size: 0.8em;
+ font-family: sans-serif;
+ }
+
.mw-jsduck-log {
position: relative;
min-height: 3em;
@@ -74,16 +85,14 @@
background: #fff;
}
</style>
+ <link rel="stylesheet" href="modules/lib/oojs-ui/oojs-ui-local.css">
+ <link rel="stylesheet"
href="modules/lib/oojs-ui/oojs-ui-mediawiki-noimages.css">
</head>
<body>
<script>
if ( window.mw ) {
mw.log = log;
}
-
- window.onerror = function ( error, filePath, linerNr ) {
- log( filePath + ':' + linerNr );
- };
/**
* Method called by jsduck to execute the example code.
--
To view, visit https://gerrit.wikimedia.org/r/235496
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00e789a2853e82e9a89d07752ce92fa6bb9615f5
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
