Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/240682

Change subject: Dahsboard: Avoid the list jump when the translation filter 
becomes sticky
......................................................................

Dahsboard: Avoid the list jump when the translation filter becomes sticky

When the header(the filters and new translation button), it creates an empty
space under that(since it is floating now) and pull the list up. This causes
a jump in the scroll position of lists. To avoid this, whenever the header 
becomes
sticky, add a padding at the top for the container with height same as the 
stikcy
header to fill the gap. This prevents the list pulled up.

This fixes the jump for both translation list and suggestion list

Change-Id: Ib1e197311c58f953281292734e8d3aea437d745e
---
M modules/dashboard/styles/ext.cx.dashboard.less
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/82/240682/1

diff --git a/modules/dashboard/styles/ext.cx.dashboard.less 
b/modules/dashboard/styles/ext.cx.dashboard.less
index 9600c90..fe35093 100644
--- a/modules/dashboard/styles/ext.cx.dashboard.less
+++ b/modules/dashboard/styles/ext.cx.dashboard.less
@@ -130,6 +130,10 @@
        padding-left: 50px;
 }
 
+.cx-translationlist-container.sticky {
+       padding-top: 120px;
+}
+
 .translation-source-language-filter,
 .translation-target-language-filter {
        background-color: #fff;
@@ -146,7 +150,6 @@
 
        background-color: #f0f0f0;
        padding: 0px;
-       margin-bottom: 20px;
 
        .cx-filters {
                .mw-ui-one-half;

-- 
To view, visit https://gerrit.wikimedia.org/r/240682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1e197311c58f953281292734e8d3aea437d745e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to