Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/240708

Change subject: Remove usage of deprecated EntityId::getNumericId
......................................................................

Remove usage of deprecated EntityId::getNumericId

Change-Id: I2819f184c0b913f50dcc070bf225c0e45f52dc8a
---
M lib/tests/phpunit/formatters/VocabularyUriFormatterTest.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/08/240708/1

diff --git a/lib/tests/phpunit/formatters/VocabularyUriFormatterTest.php 
b/lib/tests/phpunit/formatters/VocabularyUriFormatterTest.php
index 900c5b2..1f892c6 100644
--- a/lib/tests/phpunit/formatters/VocabularyUriFormatterTest.php
+++ b/lib/tests/phpunit/formatters/VocabularyUriFormatterTest.php
@@ -43,7 +43,7 @@
                $labelLookup->expects( $this->any() )
                        ->method( 'getLabel' )
                        ->will( $this->returnCallback( function( EntityId $id ) 
{
-                               if ( $id->getNumericId() > 1000 ) {
+                               if ( $id->getSerialization() === 'Q112233' ) {
                                        throw new 
LabelDescriptionLookupException( $id, 'No such label!' );
                                }
                                return new Term( 'en', 'LABEL:' . 
$id->getSerialization() );

-- 
To view, visit https://gerrit.wikimedia.org/r/240708
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2819f184c0b913f50dcc070bf225c0e45f52dc8a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to