jenkins-bot has submitted this change and it was merged. Change subject: Some bugzilla.wikimedia.org -> phabricator.wikimedia.org changes ......................................................................
Some bugzilla.wikimedia.org -> phabricator.wikimedia.org changes Changed some old bugzilla links to new phabricator links in comments, test data and error message. This reduces the need for redirects from old bugzilla to new phabricator from our source code. Change-Id: Id98278e26ce31656295a23f3cadb536859c4caa5 --- M UPGRADE M includes/GlobalFunctions.php M includes/HtmlFormatter.php M includes/api/ApiFormatPhp.php M includes/db/DatabaseMysqlBase.php M includes/db/DatabaseSqlite.php M includes/installer/Installer.php M includes/site/MediaWikiSite.php M includes/specials/SpecialUserlogin.php M languages/Language.php M maintenance/archives/patch-archive_ar_revid.sql M maintenance/archives/patch-backlinkindexes.sql M maintenance/archives/patch-categorylinksindex.sql M maintenance/cleanupPreferences.php M resources/src/mediawiki.special/mediawiki.special.upload.js M tests/phpunit/MediaWikiTestCase.php M tests/phpunit/includes/GlobalFunctions/GlobalTest.php M tests/phpunit/includes/HtmlFormatterTest.php M tests/phpunit/includes/actions/ActionTest.php M tests/phpunit/includes/api/ApiBlockTest.php M tests/phpunit/includes/api/ApiUploadTest.php M tests/phpunit/includes/api/format/ApiFormatPhpTest.php M tests/phpunit/includes/parser/PreprocessorTest.php M tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.test.js 25 files changed, 37 insertions(+), 37 deletions(-) Approvals: Anomie: Looks good to me, approved jenkins-bot: Verified diff --git a/UPGRADE b/UPGRADE index 1ff98cd..088701a 100644 --- a/UPGRADE +++ b/UPGRADE @@ -5,7 +5,7 @@ * the documentation at https://www.mediawiki.org * the mediawiki-l mailing list archive at http://lists.wikimedia.org/pipermail/mediawiki-l/ -* the bug tracker at https://bugzilla.wikimedia.org +* the bug tracker at https://phabricator.wikimedia.org for information and workarounds to common issues. diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php index 486926f..404d2cf 100644 --- a/includes/GlobalFunctions.php +++ b/includes/GlobalFunctions.php @@ -635,7 +635,7 @@ $bits = wfParseUrl( $url ); // ensure proper port for HTTPS arrives in URL - // https://bugzilla.wikimedia.org/show_bug.cgi?id=65184 + // https://phabricator.wikimedia.org/T67184 if ( $defaultProto === PROTO_HTTPS && $wgHttpsPort != 443 ) { $bits['port'] = $wgHttpsPort; } diff --git a/includes/HtmlFormatter.php b/includes/HtmlFormatter.php index 221cefb..83db268 100644 --- a/includes/HtmlFormatter.php +++ b/includes/HtmlFormatter.php @@ -75,7 +75,7 @@ // Workaround for bug that caused spaces before references // to disappear during processing: - // https://bugzilla.wikimedia.org/show_bug.cgi?id=53086 + // https://phabricator.wikimedia.org/T55086 // // Please replace with a better fix if one can be found. $html = str_replace( ' <', ' <', $html ); diff --git a/includes/api/ApiFormatPhp.php b/includes/api/ApiFormatPhp.php index 6420a5b..df9d581 100644 --- a/includes/api/ApiFormatPhp.php +++ b/includes/api/ApiFormatPhp.php @@ -69,7 +69,7 @@ ) { $this->dieUsage( 'This response cannot be represented using format=php. ' . - 'See https://bugzilla.wikimedia.org/show_bug.cgi?id=66776', + 'See https://phabricator.wikimedia.org/T68776', 'internalerror' ); } diff --git a/includes/db/DatabaseMysqlBase.php b/includes/db/DatabaseMysqlBase.php index be34242..1f87055 100644 --- a/includes/db/DatabaseMysqlBase.php +++ b/includes/db/DatabaseMysqlBase.php @@ -302,7 +302,7 @@ // We are not checking for any errors here, since // these are no errors mysql_num_rows can cause. // See http://dev.mysql.com/doc/refman/5.0/en/mysql-fetch-row.html. - // See https://bugzilla.wikimedia.org/42430 + // See https://phabricator.wikimedia.org/T44430 return $n; } diff --git a/includes/db/DatabaseSqlite.php b/includes/db/DatabaseSqlite.php index 656547b..7ece56d 100644 --- a/includes/db/DatabaseSqlite.php +++ b/includes/db/DatabaseSqlite.php @@ -806,7 +806,7 @@ // https://bugs.php.net/bug.php?id=62361 // There is an additional bug regarding sorting this data after insert // on older versions of sqlite shipped with ubuntu 12.04 - // https://bugzilla.wikimedia.org/show_bug.cgi?id=72367 + // https://phabricator.wikimedia.org/T74367 wfDebugLog( __CLASS__, __FUNCTION__ . ': Quoting value containing null byte. For consistency all binary data should have been first processed with self::encodeBlob()' ); return "x'" . bin2hex( $s ) . "'"; } else { diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php index 662469b..72e11db 100644 --- a/includes/installer/Installer.php +++ b/includes/installer/Installer.php @@ -534,7 +534,7 @@ // then some poorly-formed extensions try to call their own classes // after immediately registering them. We really need to get extension // registration out of the global scope and into a real format. - // @see https://bugzilla.wikimedia.org/67440 + // @see https://phabricator.wikimedia.org/T69440 global $wgAutoloadClasses; $wgAutoloadClasses = array(); @@ -1477,7 +1477,7 @@ * want here is $wgHooks['LoadExtensionSchemaUpdates']. This won't work * if the extension has hidden hook registration in $wgExtensionFunctions, * but we're not opening that can of worms - * @see https://bugzilla.wikimedia.org/show_bug.cgi?id=26857 + * @see https://phabricator.wikimedia.org/T28857 */ global $wgAutoloadClasses; $wgAutoloadClasses = array(); diff --git a/includes/site/MediaWikiSite.php b/includes/site/MediaWikiSite.php index 95631f8..029919c 100644 --- a/includes/site/MediaWikiSite.php +++ b/includes/site/MediaWikiSite.php @@ -113,9 +113,9 @@ return $t->getPrefixedText(); } else { - // Make sure the string is normalized into NFC (due to the bug 40017) + // Make sure the string is normalized into NFC (due to T42017) // but do nothing to the whitespaces, that should work appropriately. - // @see https://bugzilla.wikimedia.org/show_bug.cgi?id=40017 + // @see https://phabricator.wikimedia.org/T42017 $pageName = UtfNormal\Validator::cleanUp( $pageName ); // Build the args for the specific call diff --git a/includes/specials/SpecialUserlogin.php b/includes/specials/SpecialUserlogin.php index 21f1194..ee78a61 100644 --- a/includes/specials/SpecialUserlogin.php +++ b/includes/specials/SpecialUserlogin.php @@ -1380,7 +1380,7 @@ if ( $this->mType == 'signup' ) { // XXX hack pending RL or JS parse() support for complex content messages - // https://bugzilla.wikimedia.org/show_bug.cgi?id=25349 + // https://phabricator.wikimedia.org/T27349 $out->addJsConfigVars( 'wgCreateacctImgcaptchaHelp', $this->msg( 'createacct-imgcaptcha-help' )->parse() ); diff --git a/languages/Language.php b/languages/Language.php index 1613536..8265d69 100644 --- a/languages/Language.php +++ b/languages/Language.php @@ -2678,7 +2678,7 @@ # Even with //IGNORE iconv can whine about illegal characters in # *input* string. We just ignore those too. # REF: http://bugs.php.net/bug.php?id=37166 - # REF: https://bugzilla.wikimedia.org/show_bug.cgi?id=16885 + # REF: https://phabricator.wikimedia.org/T18885 MediaWiki\suppressWarnings(); $text = iconv( $in, $out . '//IGNORE', $string ); MediaWiki\restoreWarnings(); diff --git a/maintenance/archives/patch-archive_ar_revid.sql b/maintenance/archives/patch-archive_ar_revid.sql index 3b3fdee..f3b9c3c 100644 --- a/maintenance/archives/patch-archive_ar_revid.sql +++ b/maintenance/archives/patch-archive_ar_revid.sql @@ -1,3 +1,3 @@ -- Hopefully temporary index. --- For https://bugzilla.wikimedia.org/show_bug.cgi?id=21279 +-- For https://phabricator.wikimedia.org/T23279 CREATE INDEX /*i*/ar_revid ON /*$wgDBprefix*/archive ( ar_rev_id ); \ No newline at end of file diff --git a/maintenance/archives/patch-backlinkindexes.sql b/maintenance/archives/patch-backlinkindexes.sql index 22cc587..9a991b8 100644 --- a/maintenance/archives/patch-backlinkindexes.sql +++ b/maintenance/archives/patch-backlinkindexes.sql @@ -1,7 +1,7 @@ -- -- patch-backlinkindexes.sql -- --- Per bug 6440 / http://bugzilla.wikimedia.org/show_bug.cgi?id=6440 +-- Per task T8440 / https://phabricator.wikimedia.org/T8440 -- -- Improve performance of the "what links here"-type queries -- diff --git a/maintenance/archives/patch-categorylinksindex.sql b/maintenance/archives/patch-categorylinksindex.sql index 24ad84f..e2b2c3a 100644 --- a/maintenance/archives/patch-categorylinksindex.sql +++ b/maintenance/archives/patch-categorylinksindex.sql @@ -1,7 +1,7 @@ -- -- patch-categorylinksindex.sql -- --- Per bug 10280 / http://bugzilla.wikimedia.org/show_bug.cgi?id=10280 +-- Per task T12280 / https://phabricator.wikimedia.org/T12280 -- -- Improve enum continuation performance of the what pages belong to a category query -- diff --git a/maintenance/cleanupPreferences.php b/maintenance/cleanupPreferences.php index 06ae17f..4e19b79 100644 --- a/maintenance/cleanupPreferences.php +++ b/maintenance/cleanupPreferences.php @@ -19,7 +19,7 @@ * * @file * @author TyA <[email protected]> - * @see [[bugzilla:30976]] + * @see https://phabricator.wikimedia.org/T32976 * @ingroup Maintenance */ diff --git a/resources/src/mediawiki.special/mediawiki.special.upload.js b/resources/src/mediawiki.special/mediawiki.special.upload.js index 677d26d..c6ae5ac 100644 --- a/resources/src/mediawiki.special/mediawiki.special.upload.js +++ b/resources/src/mediawiki.special/mediawiki.special.upload.js @@ -263,7 +263,7 @@ * * TODO: Is there a way we can ask the browser what's supported in `<img>`s? * - * TODO: Put SVG back after working around Firefox 7 bug <https://bugzilla.wikimedia.org/show_bug.cgi?id=31643> + * TODO: Put SVG back after working around Firefox 7 bug <https://phabricator.wikimedia.org/T33643> * * @param {File} file * @return {boolean} diff --git a/tests/phpunit/MediaWikiTestCase.php b/tests/phpunit/MediaWikiTestCase.php index 7dc7027..ec95665 100644 --- a/tests/phpunit/MediaWikiTestCase.php +++ b/tests/phpunit/MediaWikiTestCase.php @@ -1151,7 +1151,7 @@ /** * Note: we are overriding this method to remove the deprecated error - * @see https://bugzilla.wikimedia.org/show_bug.cgi?id=69505 + * @see https://phabricator.wikimedia.org/T71505 * @see https://github.com/sebastianbergmann/phpunit/issues/1292 * @deprecated * diff --git a/tests/phpunit/includes/GlobalFunctions/GlobalTest.php b/tests/phpunit/includes/GlobalFunctions/GlobalTest.php index e89e36f..69dcd4c 100644 --- a/tests/phpunit/includes/GlobalFunctions/GlobalTest.php +++ b/tests/phpunit/includes/GlobalFunctions/GlobalTest.php @@ -551,10 +551,10 @@ public static function provideMakeUrlIndexes() { return array( + // Testcase for T30627 array( - // just a regular :) - 'https://bugzilla.wikimedia.org/show_bug.cgi?id=28627', - array( 'https://org.wikimedia.bugzilla./show_bug.cgi?id=28627' ) + 'https://example.org/test.cgi?id=12345', + array( 'https://org.example./test.cgi?id=12345' ) ), array( // mailtos are handled special @@ -563,7 +563,7 @@ array( 'mailto:org.wikimedia@wiki.' ) ), - // file URL cases per bug 28627... + // file URL cases per T30627... array( // three slashes: local filesystem path Unix-style 'file:///whatever/you/like.txt', @@ -587,12 +587,12 @@ // Those will survive the algorithm but with results that // are less consistent. - // protocol-relative URL cases per bug 29854... + // protocol-relative URL cases per T31854... array( - '//bugzilla.wikimedia.org/show_bug.cgi?id=28627', + '//example.org/test.cgi?id=12345', array( - 'http://org.wikimedia.bugzilla./show_bug.cgi?id=28627', - 'https://org.wikimedia.bugzilla./show_bug.cgi?id=28627' + 'http://org.example./test.cgi?id=12345', + 'https://org.example./test.cgi?id=12345' ) ), ); diff --git a/tests/phpunit/includes/HtmlFormatterTest.php b/tests/phpunit/includes/HtmlFormatterTest.php index 1c3e853..df54914 100644 --- a/tests/phpunit/includes/HtmlFormatterTest.php +++ b/tests/phpunit/includes/HtmlFormatterTest.php @@ -114,7 +114,7 @@ array(), $removeTags, // Have some rules to trigger a DOM parse ), - // https://bugzilla.wikimedia.org/show_bug.cgi?id=53086 + // https://phabricator.wikimedia.org/T55086 array( 'Foo<sup id="cite_ref-1" class="reference"><a href="#cite_note-1">[1]</a></sup>' . ' <a href="/wiki/Bar" title="Bar" class="mw-redirect">Bar</a>', diff --git a/tests/phpunit/includes/actions/ActionTest.php b/tests/phpunit/includes/actions/ActionTest.php index 3babb97..63e0c8e 100644 --- a/tests/phpunit/includes/actions/ActionTest.php +++ b/tests/phpunit/includes/actions/ActionTest.php @@ -92,7 +92,7 @@ } public function testGetActionName_editredlinkWorkaround() { - // See https://bugzilla.wikimedia.org/show_bug.cgi?id=20966 + // See https://phabricator.wikimedia.org/T22966 $context = $this->getContext( 'editredlink' ); $actionName = Action::getActionName( $context ); @@ -100,7 +100,7 @@ } public function testGetActionName_historysubmitWorkaround() { - // See https://bugzilla.wikimedia.org/show_bug.cgi?id=20966 + // See https://phabricator.wikimedia.org/T22966 $context = $this->getContext( 'historysubmit' ); $actionName = Action::getActionName( $context ); @@ -108,7 +108,7 @@ } public function testGetActionName_revisiondeleteWorkaround() { - // See https://bugzilla.wikimedia.org/show_bug.cgi?id=20966 + // See https://phabricator.wikimedia.org/T22966 $context = $this->getContext( 'historysubmit' ); $context->getRequest()->setVal( 'revisiondelete', true ); $actionName = Action::getActionName( $context ); diff --git a/tests/phpunit/includes/api/ApiBlockTest.php b/tests/phpunit/includes/api/ApiBlockTest.php index 575efd6..d499a75 100644 --- a/tests/phpunit/includes/api/ApiBlockTest.php +++ b/tests/phpunit/includes/api/ApiBlockTest.php @@ -30,11 +30,11 @@ /** * This test has probably always been broken and use an invalid token - * Bug tracking brokenness is https://bugzilla.wikimedia.org/35646 + * Bug tracking brokenness is https://phabricator.wikimedia.org/T37646 * * Root cause is https://gerrit.wikimedia.org/r/3434 * Which made the Block/Unblock API to actually verify the token - * previously always considered valid (bug 34212). + * previously always considered valid (T37646). */ public function testMakeNormalBlock() { $tokens = $this->getTokens(); diff --git a/tests/phpunit/includes/api/ApiUploadTest.php b/tests/phpunit/includes/api/ApiUploadTest.php index c852d72..40de254 100644 --- a/tests/phpunit/includes/api/ApiUploadTest.php +++ b/tests/phpunit/includes/api/ApiUploadTest.php @@ -11,7 +11,7 @@ * @todo Port the other Upload tests, and other API tests to this framework * * @todo Broken test, reports false errors from time to time. - * See https://bugzilla.wikimedia.org/26169 + * See https://phabricator.wikimedia.org/T28169 * * @todo This is pretty sucky... needs to be prettified. * diff --git a/tests/phpunit/includes/api/format/ApiFormatPhpTest.php b/tests/phpunit/includes/api/format/ApiFormatPhpTest.php index 0cb44e9..09c7c0c 100644 --- a/tests/phpunit/includes/api/format/ApiFormatPhpTest.php +++ b/tests/phpunit/includes/api/format/ApiFormatPhpTest.php @@ -134,7 +134,7 @@ } catch ( UsageException $ex ) { ob_end_clean(); $this->assertSame( - 'This response cannot be represented using format=php. See https://bugzilla.wikimedia.org/show_bug.cgi?id=66776', + 'This response cannot be represented using format=php. See https://phabricator.wikimedia.org/T68776', $ex->getMessage(), 'Expected exception' ); diff --git a/tests/phpunit/includes/parser/PreprocessorTest.php b/tests/phpunit/includes/parser/PreprocessorTest.php index 345fd0a..1ebba1a 100644 --- a/tests/phpunit/includes/parser/PreprocessorTest.php +++ b/tests/phpunit/includes/parser/PreprocessorTest.php @@ -193,7 +193,7 @@ } /** - * Tests from Bug 28642 · https://bugzilla.wikimedia.org/28642 + * Tests from T30642 · https://phabricator.wikimedia.org/T30642 */ public static function provideHeadings() { // @codingStandardsIgnoreStart Ignore Generic.Files.LineLength.TooLong diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js index e7f4517..161b8e1 100644 --- a/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js +++ b/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js @@ -41,7 +41,7 @@ 'gender-msg-currentuser': '{{GENDER:|blue|pink|green}}', 'plural-msg': 'Found $1 {{PLURAL:$1|item|items}}', - // See https://bugzilla.wikimedia.org/69993 + // See https://phabricator.wikimedia.org/T71993 'plural-msg-explicit-forms-nested': 'Found {{PLURAL:$1|$1 results|0=no results in {{SITENAME}}|1=$1 result}}', // Assume the grammar form grammar_case_foo is not valid in any language 'grammar-msg': 'Przeszukaj {{GRAMMAR:grammar_case_foo|{{SITENAME}}}}', diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js index 111d85b..cec0552 100644 --- a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js +++ b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js @@ -186,7 +186,7 @@ hello = mw.message( 'hello' ); - // https://bugzilla.wikimedia.org/show_bug.cgi?id=44459 + // https://phabricator.wikimedia.org/T46459 assert.equal( hello.format, 'text', 'Message property "format" defaults to "text"' ); assert.strictEqual( hello.map, mw.messages, 'Message property "map" defaults to the global instance in mw.messages' ); -- To view, visit https://gerrit.wikimedia.org/r/237903 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id98278e26ce31656295a23f3cadb536859c4caa5 Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Anomie <[email protected]> Gerrit-Reviewer: Cscott <[email protected]> Gerrit-Reviewer: Daniel Friesen <[email protected]> Gerrit-Reviewer: Edokter <[email protected]> Gerrit-Reviewer: Jack Phoenix <[email protected]> Gerrit-Reviewer: Jackmcbarn <[email protected]> Gerrit-Reviewer: Jjanes <[email protected]> Gerrit-Reviewer: Legoktm <[email protected]> Gerrit-Reviewer: Parent5446 <[email protected]> Gerrit-Reviewer: Springle <[email protected]> Gerrit-Reviewer: Umherirrender <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
