Ladsgroup has uploaded a new change for review.
https://gerrit.wikimedia.org/r/241043
Change subject: More tests based on code coverage reprots
......................................................................
More tests based on code coverage reprots
Change-Id: I009710d9903a178e213602a7d9a2555e711fffea
---
M pywikibase/claim.py
M tests/test_claim.py
M tests/test_wikibasepage.py
3 files changed, 35 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/wikibase
refs/changes/43/241043/1
diff --git a/pywikibase/claim.py b/pywikibase/claim.py
index 530d0cd..21ec9b1 100644
--- a/pywikibase/claim.py
+++ b/pywikibase/claim.py
@@ -259,10 +259,6 @@
"""Set the rank of the Claim."""
self.rank = rank
- def changeRank(self, rank):
- """Change the rank of the Claim and save."""
- self.rank = rank
-
def getSources(self):
"""
Return a list of sources, each being a list of Claims.
diff --git a/tests/test_claim.py b/tests/test_claim.py
index 6d1cbfd..c953ae6 100644
--- a/tests/test_claim.py
+++ b/tests/test_claim.py
@@ -35,6 +35,14 @@
self.assertRaises(ValueError, Claim, 'P31', isQualifier=True,
isReference=True)
+ def test_set_target(self):
+ claim = Claim('P144', datatype='wikibase-item')
+ self.assertRaises(ValueError, claim.setTarget, "Hello!")
+
+ claim = Claim('P144', datatype='time')
+ self.assertRaises(ValueError, claim.setTarget, ItemPage('Q5'))
+ self.assertRaises(ValueError, claim.setTarget, "Hello!")
+
def test_sources(self):
self.assertIsInstance(self.claim1.sources, list)
self.assertIsInstance(self.claim1.sources[0], OrderedDict)
@@ -83,6 +91,13 @@
self.assertTrue(self.claim3.target_equals('Alan Turing Aged 16.jpg'))
self.assertFalse(self.claim1.target_equals('Q6'))
+ def test_rank(self):
+ self.assertEqual(self.claim1.getRank(), 'normal')
+
+ claim = Claim('P134', datatype='wikibase-item')
+ claim.setRank('preferred')
+ self.assertEqual(claim.getRank(), 'preferred')
+ self.assertEqual(claim.rank, 'preferred')
if __name__ == '__main__':
unittest.main()
diff --git a/tests/test_wikibasepage.py b/tests/test_wikibasepage.py
index daeb103..7fbb532 100644
--- a/tests/test_wikibasepage.py
+++ b/tests/test_wikibasepage.py
@@ -2,7 +2,7 @@
import json
import os
-from pywikibase import WikibasePage, Claim
+from pywikibase import WikibasePage, Claim, ItemPage
try:
unicode = unicode
@@ -24,6 +24,8 @@
wb_page = WikibasePage('Q7251')
self.assertNotEqual(self.wb_page, WikibasePage())
self.assertEqual(self.wb_page, wb_page)
+ wb_page = WikibasePage()
+ self.assertRaises(ValueError, wb_page.get)
def test_descriptions(self):
self.assertEqual(len(self.wb_page.descriptions), 22)
@@ -58,5 +60,22 @@
self.assertEqual(content['claims'][p_number],
json_res['claims'][p_number])
+ def test_diffto(self):
+ wb_page = self.wb_page
+ content = wb_page.toJSON()
+ claim_json = wb_page.claims['P31'][0].toJSON()
+ wb_page.claims['P31'][0].target = ItemPage('Q6')
+ res = wb_page.toJSON(diffto=claim_json)
+ self.assertEqual(content['labels'], res['labels'])
+ self.assertEqual(content['descriptions'], res['descriptions'])
+ self.assertEqual(content['aliases'], res['aliases'])
+ for p_number in content['claims']:
+ if p_number != 'P31':
+ self.assertEqual(content['claims'][p_number],
+ res['claims'][p_number])
+ snak_json = res['claims']['P31'][0]['mainsnak']
+ self.assertEqual(snak_json['datavalue']['value']['numeric-id'], 6)
+
+
if __name__ == '__main__':
unittest.main()
--
To view, visit https://gerrit.wikimedia.org/r/241043
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I009710d9903a178e213602a7d9a2555e711fffea
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
