Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/241490
Change subject: Increase lead text shadow
......................................................................
Increase lead text shadow
Increase the lead text shadow when displaying images. This makes text
easier to read on light images.
Change-Id: I9151eefef47222aaedff1260ad515d86b98324e5
---
M app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
M app/src/main/res/values/colors.xml
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/90/241490/1
diff --git
a/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
b/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
index a60ea86..3ab4ba7 100755
--- a/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
+++ b/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
@@ -334,7 +334,7 @@
// set the color of the title
pageTitleText.setTextColor(getColor(R.color.lead_text_color));
// and give it a nice drop shadow!
- pageTitleText.setShadowLayer(2, 1, 1,
getColor(R.color.lead_text_shadow));
+ pageTitleText.setShadowLayer(3, 2, 2,
getColor(R.color.lead_text_shadow));
// set the title container background to be a gradient
ViewUtil.setBackgroundDrawable(pageTitleText, pageTitleGradient);
}
diff --git a/app/src/main/res/values/colors.xml
b/app/src/main/res/values/colors.xml
index 21adf77..ef939cc 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -81,7 +81,7 @@
<color name="list_item_highlight">#60808080</color>
<color name="list_item_selected">#20808080</color>
<color name="lead_text_color">#fff0f0f0</color>
- <color name="lead_text_shadow">#80000000</color>
+ <color name="lead_text_shadow">#e000</color>
<color name="lead_disabled_text_light">#ff000000</color>
<color name="lead_disabled_text_dark">#ffffffff</color>
--
To view, visit https://gerrit.wikimedia.org/r/241490
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9151eefef47222aaedff1260ad515d86b98324e5
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
