Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/241915
Change subject: Fix lead title offset regression
......................................................................
Fix lead title offset regression
The lead title and subtitle now share a single TextView and should be
measured together.
Change-Id: Id9927ee0cd14c119c7b015acf19c6d8ad81b3790
---
M app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/15/241915/1
diff --git
a/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
b/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
index a60ea86..6904320 100755
--- a/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
+++ b/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
@@ -226,6 +226,8 @@
// set the page title text, and honor any HTML formatting in the title
pageTitleText.setText(Html.fromHtml(getPage().getDisplayTitle()));
+ // Set the subtitle, too, so text measurements are accurate.
+ layoutWikiDataDescription(getTitle().getDescription());
// kick off the (asynchronous) laying out of the page title text
layoutPageTitle((int) (getDimension(R.dimen.titleTextSize)
@@ -353,8 +355,7 @@
if (!isMainPage()) {
// make everything visible!
imageContainer.setVisibility(View.VISIBLE);
- // kick off loading of the WikiData description
- layoutWikiDataDescription(getTitle().getDescription());
+ pageTitleText.setVisibility(View.VISIBLE);
}
}
@@ -398,7 +399,6 @@
pageTitleText.setText(title);
}
}
- pageTitleText.setVisibility(View.VISIBLE);
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/241915
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9927ee0cd14c119c7b015acf19c6d8ad81b3790
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
