jenkins-bot has submitted this change and it was merged. Change subject: Fixed Metrics/LineLength RuboCop offense ......................................................................
Fixed Metrics/LineLength RuboCop offense Bug: T114095 Change-Id: I598e4782e97c7b571f92a802c816db6567169d1d --- M .rubocop.yml D .rubocop_todo.yml M tests/browser/features/support/pages/article_page.rb 3 files changed, 8 insertions(+), 20 deletions(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified diff --git a/.rubocop.yml b/.rubocop.yml index e4392ba..84567a5 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,11 +1,8 @@ -inherit_from: .rubocop_todo.yml - AllCops: StyleGuideCopsOnly: true -# uncomment when the offese is fixed -# Metrics/LineLength: -# Max: 100 +Metrics/LineLength: + Max: 100 Metrics/MethodLength: Enabled: false diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml deleted file mode 100644 index 3857e04..0000000 --- a/.rubocop_todo.yml +++ /dev/null @@ -1,12 +0,0 @@ -# This configuration was generated by -# `rubocop --auto-gen-config` -# on 2015-09-29 12:45:22 +0200 using RuboCop version 0.34.2. -# The point is for the user to remove these configuration records -# one by one as the offenses are removed from the code base. -# Note that changes in the inspected code, or installation of new -# versions of RuboCop, may require this file to be generated again. - -# Offense count: 6 -# Configuration parameters: AllowURI, URISchemes. -Metrics/LineLength: - Max: 108 diff --git a/tests/browser/features/support/pages/article_page.rb b/tests/browser/features/support/pages/article_page.rb index 91952d9..bb1902b 100644 --- a/tests/browser/features/support/pages/article_page.rb +++ b/tests/browser/features/support/pages/article_page.rb @@ -8,13 +8,16 @@ li(:notifications_message, css: '#pt-notifications-message') link(:notifications_badge_alert, css: '#pt-notifications-alert a') link(:notifications_badge_message, css: '#pt-notifications-message a') - div(:popup_alert, css: '#pt-notifications-alert .mw-echo-ui-notificationBadgeButtonPopupWidget-popup') - div(:popup_message, css: '#pt-notifications-message .mw-echo-ui-notificationBadgeButtonPopupWidget-popup') + div(:popup_alert, + css: '#pt-notifications-alert .mw-echo-ui-notificationBadgeButtonPopupWidget-popup') + div(:popup_message, + css: '#pt-notifications-message .mw-echo-ui-notificationBadgeButtonPopupWidget-popup') # Popup elements button(:mark_all_read_button, css: '.mw-echo-ui-notificationsWidget-markAllReadButton') def popup_title(popupElement) - popupElement.when_present.span_element(css: '.oo-ui-popupWidget-head > .oo-ui-labelElement-label') + popupElement.when_present.span_element( + css: '.oo-ui-popupWidget-head > .oo-ui-labelElement-label') end # span(:popup_title, css: '.oo-ui-popupWidget-head > .oo-ui-labelElement-label') -- To view, visit https://gerrit.wikimedia.org/r/242120 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I598e4782e97c7b571f92a802c816db6567169d1d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: Dduvall <dduv...@wikimedia.org> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org> Gerrit-Reviewer: Mooeypoo <mor...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
