[MediaWiki-commits] [Gerrit] Enable a few more syntax highlighting rules when editing. - change (apps...wikipedia)

[Dbrant (Code Review)]

Dbrant has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/242146

Change subject: Enable a few more syntax highlighting rules when editing.
......................................................................

Enable a few more syntax highlighting rules when editing.

Syntax highlighting when editing wikitext in the app has been available
for over a year, but has so far been disabled, in the hopes of coming up
with an entirely transformative editing experience in the app. Since we
haven't created such an experience just yet, presenting the user with
modestly highlighted wikitext is better than a solid wall of unhighlighted
wikitext.

Change-Id: I03065408d8b01d82ff262a65c0b957637fbeaafc
---
M app/src/main/java/org/wikipedia/editing/richtext/SyntaxHighlighter.java
M app/src/main/res/values/colors.xml
2 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/46/242146/1

diff --git 
a/app/src/main/java/org/wikipedia/editing/richtext/SyntaxHighlighter.java 
b/app/src/main/java/org/wikipedia/editing/richtext/SyntaxHighlighter.java
index b64d0e8..a8af86d 100644
--- a/app/src/main/java/org/wikipedia/editing/richtext/SyntaxHighlighter.java
+++ b/app/src/main/java/org/wikipedia/editing/richtext/SyntaxHighlighter.java
@@ -2,6 +2,7 @@
 
 import android.app.Activity;
 import android.graphics.Color;
+import android.graphics.Typeface;
 import android.os.Handler;
 import android.os.Looper;
 import android.text.Editable;
@@ -54,7 +55,6 @@
             }
         }));
 
-        /*
         // internal link:
         syntaxRules.add(new SyntaxRule("[[", "]]", new 
SyntaxRule.SyntaxRuleStyle() {
             @Override
@@ -68,7 +68,7 @@
         syntaxRules.add(new SyntaxRule("[", "]", new 
SyntaxRule.SyntaxRuleStyle() {
             @Override
             public SpanExtents createSpan(int spanStart, SyntaxRule 
syntaxItem) {
-                return new 
ColorSpanEx(parentActivity.getResources().getColor(R.color.syntax_highlight_extlink),
+                return new 
ColorSpanEx(parentActivity.getResources().getColor(Utils.getThemedAttributeId(parentActivity,
 R.attr.link_color)),
                                                  Color.TRANSPARENT, spanStart, 
syntaxItem);
             }
         }));
@@ -106,6 +106,7 @@
             }
         }));
 
+        /*
         // section level 4:
         syntaxRules.add(new SyntaxRule("====", "====", new 
SyntaxRule.SyntaxRuleStyle() {
             @Override
diff --git a/app/src/main/res/values/colors.xml 
b/app/src/main/res/values/colors.xml
index 21adf77..22fa185 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -90,6 +90,7 @@
 
     <color name="syntax_highlight_template_light">#a0a0a0</color>
     <color name="syntax_highlight_template_dark">#505050</color>
+    <color name="syntax_highlight_htmltag">#484</color>
 
     <color name="widget_background">#80ffffff</color>
     <color name="widget_title_text">#ff606060</color>

-- 
To view, visit https://gerrit.wikimedia.org/r/242146
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I03065408d8b01d82ff262a65c0b957637fbeaafc
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits