Andrew Bogott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/242171
Change subject: dataset: Remove needless quotes around a 'true'
......................................................................
dataset: Remove needless quotes around a 'true'
A regular old boolean will suit us fine, and the check
in the template as written is broken for a quoted
boolean anyway.
Bug: T113783
Change-Id: I768686f22dd512feafbac0b4de8d18e8064d004a
---
M modules/dataset/manifests/rsync/default.pp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/71/242171/1
diff --git a/modules/dataset/manifests/rsync/default.pp
b/modules/dataset/manifests/rsync/default.pp
index 5c8d7d1..f0d21cc 100644
--- a/modules/dataset/manifests/rsync/default.pp
+++ b/modules/dataset/manifests/rsync/default.pp
@@ -1,5 +1,5 @@
class dataset::rsync::default(
- $rsync_enable = 'true', # this is a string used in a template
+ $rsync_enable = true,
$public = true,
$rsync_opts = '--bwlimit=50000',
$rsync_config_file = undef
--
To view, visit https://gerrit.wikimedia.org/r/242171
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I768686f22dd512feafbac0b4de8d18e8064d004a
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott <abog...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
