01tonythomas has uploaded a new change for review.
https://gerrit.wikimedia.org/r/242268
Change subject: Remove unused code from CirrusSearch File
......................................................................
Remove unused code from CirrusSearch File
Few issues PHPStorm was pointing out
Change-Id: Ifb9298a2f3a2cbdd3a34363c13e40e898455dfa2
---
M includes/ElasticsearchIntermediary.php
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch
refs/changes/68/242268/1
diff --git a/includes/ElasticsearchIntermediary.php
b/includes/ElasticsearchIntermediary.php
index 018ed5b..ee23b57 100644
--- a/includes/ElasticsearchIntermediary.php
+++ b/includes/ElasticsearchIntermediary.php
@@ -93,7 +93,7 @@
$this->user = $user;
$this->slowMillis = round( 1000 * $slowSeconds );
$this->ut = UserTesting::getInstance();
- $config = ConfigFactory::getDefaultInstance()->makeConfig(
'CirrusSearch' );
+ ConfigFactory::getDefaultInstance()->makeConfig( 'CirrusSearch'
);
}
/**
@@ -161,7 +161,6 @@
FormatJson::encode( $parameters ),
);
- $tests = array();
$logger = LoggerFactory::getInstance( 'CirrusSearchUserTesting'
);
foreach ( $ut->getActiveTestNames() as $test ) {
$bucket = $ut->getBucket( $test );
@@ -302,7 +301,7 @@
/**
* Log the completion of a request to Elasticsearch.
- * @return int number of milliseconds it took to complete the request
+ * @return bool|int number of milliseconds it took to complete the
request
*/
private function finishRequest() {
global $wgCirrusSearchLogElasticRequests;
@@ -311,7 +310,7 @@
LoggerFactory::getInstance( 'CirrusSearch' )->warning(
'finishRequest called without staring a request'
);
- return;
+ return false;
}
$endTime = microtime( true );
$took = round( ( $endTime - $this->requestStart ) * 1000 );
--
To view, visit https://gerrit.wikimedia.org/r/242268
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb9298a2f3a2cbdd3a34363c13e40e898455dfa2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: 01tonythomas <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
