Spage has uploaded a new change for review.
https://gerrit.wikimedia.org/r/242372
Change subject: Output dataAfterContent like other skins
......................................................................
Output dataAfterContent like other skins
Other skins output this piece of data at the end of the page.
This patch adds a mustache comment explaining the bottom of page.
To test, use the skin in conjunction with some extension that has a hook
for SkinAfterContent.
Change-Id: Ie4e8de441ae60cb0e8a472a6cc5110195179282b
---
M templates/Skin.php
M templates/Skin.template
2 files changed, 10 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Blueprint
refs/changes/72/242372/1
diff --git a/templates/Skin.php b/templates/Skin.php
index 5327c6d..7d2355f 100644
--- a/templates/Skin.php
+++ b/templates/Skin.php
@@ -29,7 +29,6 @@
'partials' => array(),
'scopes' => array(),
'sp_vars' => array('root' => $in),
- 'lcrun' => 'LCRun3',
'funcs' => array(
'v' => function ($cx, $base, $path) {
$count = count($cx['scopes']);
@@ -64,7 +63,7 @@
case -1:
$base = $cx['sp_vars']['root'];
break;
- case -2:
+ case -2;
return null;
default:
$base = $cx['scopes'][$count];
@@ -276,7 +275,7 @@
'.$cx['funcs']['v']($cx, $in, array('bodytext')).'
</div>
</div>
-
+'.htmlentities((string)$cx['funcs']['v']($cx, $in, array('dataAfterContent')),
ENT_QUOTES, 'UTF-8').'
'.$cx['funcs']['v']($cx, $in, array('debughtml')).'
'.$cx['funcs']['v']($cx, $in, array('bottomscripts')).'
'.$cx['funcs']['v']($cx, $in, array('reporttime')).'
@@ -284,4 +283,4 @@
</html>
';
}
-?>
+?>
\ No newline at end of file
diff --git a/templates/Skin.template b/templates/Skin.template
index 620f7bf..a833cd7 100644
--- a/templates/Skin.template
+++ b/templates/Skin.template
@@ -63,7 +63,13 @@
{{{bodytext}}}
</div>
</div>
-
+{{! PHP skins tend to
+ echo $this->afterContent();
+ $this->html( 'dataAfterContent' );
+ $this->printTrail()
+printTrail() outputs debughtml, bottomscripts, reporttime
+}}
+{{dataAfterContent}}
{{{debughtml}}}
{{{bottomscripts}}}
{{{reporttime}}}
--
To view, visit https://gerrit.wikimedia.org/r/242372
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4e8de441ae60cb0e8a472a6cc5110195179282b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Blueprint
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
