jenkins-bot has submitted this change and it was merged.
Change subject: NotificationBadgeWidget: Fix button icon positioning for change
in OOUI
......................................................................
NotificationBadgeWidget: Fix button icon positioning for change in OOUI
OOUI now uses absolute positioning for these icons, which breaks
the centered text model we'd like to use. Longer-term we should
use a different widget for these buttons, or perhaps a widget of
our own, but for now let's hack around that by undoing the
absolute positioning.
Change-Id: I8cc1fd69eeedde00facec80d82a21d5cc5610992
---
M modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Mooeypoo: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
b/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
index 09c018b..992233d 100644
--- a/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
+++ b/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
@@ -32,6 +32,13 @@
line-height: 4em;
margin: 0;
border: 0;
+
+ .oo-ui-iconElement-icon {
+ // HACK: these are absolutely
positioned in OOUI, and our line-height: 4em;
+ // rule breaks that.
+ // FIXME: We should really use a
different widget here
+ position: static;
+ }
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/242401
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cc1fd69eeedde00facec80d82a21d5cc5610992
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
