Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/242408
Change subject: Fix Echo popup alignment in RTL
......................................................................
Fix Echo popup alignment in RTL
Bug: T114184
Change-Id: I2b2b8c332efbcf0e646bf77f688433559da7b628
(cherry picked from commit 16ddd5c7d74d6278f63126404a9bf29023fddeca)
---
M modules/nojs/mw.echo.badge.less
M modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
2 files changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/08/242408/1
diff --git a/modules/nojs/mw.echo.badge.less b/modules/nojs/mw.echo.badge.less
index 0ede1fb..eb0b606 100644
--- a/modules/nojs/mw.echo.badge.less
+++ b/modules/nojs/mw.echo.badge.less
@@ -45,7 +45,14 @@
#pt-notifications-message & {
margin-left: @badge-distance-adjustment;
- + .oo-ui-popupWidget {
+ body.ltr & + .oo-ui-popupWidget {
+ // Only add a left adjustment for LTR pages.
+ // In LTR, the correction above moves the badge from
the left
+ // which means we have to adjust the positioning of the
anchor
+ // to be in the middle of the badge.
+ // In RTL, however, the above will be flipped to
margin-right
+ // which doesn't affect the positioning of the anchor
and hence
+ // doesn't require a correction.
left: (1em + @badge-distance-adjustment);
}
}
diff --git a/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
b/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
index a88c3e3..09c018b 100644
--- a/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
+++ b/modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
@@ -43,6 +43,7 @@
font-size: 0.875em / 0.75em;
// Align the popup with the center of the button
+ /* @noflip */
left: 1em;
}
--
To view, visit https://gerrit.wikimedia.org/r/242408
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b2b8c332efbcf0e646bf77f688433559da7b628
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: wmf/1.26wmf24
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
