Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/242540
Change subject: Use sharedCacheDuration setting for
CachingOtherProjectsSitesProvider
......................................................................
Use sharedCacheDuration setting for CachingOtherProjectsSitesProvider
Warning, I'm not absolutely sure if the fact that this could not be
configured was intended. The settings are currently used in two places:
SqlStore (repo) and DirectSqlStore (client). All three places are using
an ObjectCache instance via one of the wfGet(Main)Cache global functions.
All three usages defaulted to the exact same wgMainCacheType cache type
anyway.
TL;DR: With the default settings, this does not change anything, but
makes this configurable.
Change-Id: I7d60f8672a2bfdb2ce15bd2ea2f957d821b10623
---
M client/includes/WikibaseClient.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/40/242540/1
diff --git a/client/includes/WikibaseClient.php
b/client/includes/WikibaseClient.php
index 878cebc..ccf86b9 100644
--- a/client/includes/WikibaseClient.php
+++ b/client/includes/WikibaseClient.php
@@ -872,8 +872,8 @@
return new CachingOtherProjectsSitesProvider(
$otherProjectsSitesProvider,
- wfGetMainCache(),
- 60 * 60
+ wfGetCache( $this->settings->getSetting(
'sharedCacheType' ) ),
+ $this->settings->getSetting( 'sharedCacheDuration' )
);
}
--
To view, visit https://gerrit.wikimedia.org/r/242540
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d60f8672a2bfdb2ce15bd2ea2f957d821b10623
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits