jenkins-bot has submitted this change and it was merged.
Change subject: MediaWiki theme: Make PHP DropdownInputWidget look closer to JS
version
......................................................................
MediaWiki theme: Make PHP DropdownInputWidget look closer to JS version
* Explicitly set height for JS DropdownWidget to match the height of
PHP DropdownWidget (which uses a <select>) and other widgets.
We expected to get 2.275em as 2*0.5+1.275 (2*padding+label), but the
widget also has a border, which added 2*1px to the height.
'box-sizing: border-box' doesn't help if you don't actually set the
desired height.
* Match 'border-radius' (although it is hardly visible).
* Add 'padding-left' to match JS label's 'margin-left'.
* Add 'vertical-align: middle', just in case.
Bug: T113492
Change-Id: Ieabb382f8ec4b65ea08331e59e424b73bf9fe597
---
M src/themes/mediawiki/widgets.less
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index e2cef64..b0b0bdf 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -105,7 +105,8 @@
.oo-ui-inline-spacing(0.5em);
&-handle {
- padding: 0.5em 0;
+ padding: 0.3em 0;
+ height: 2.275em;
border: 1px solid #ccc;
border-radius: 0.1em;
@@ -428,6 +429,9 @@
font-family: inherit;
.oo-ui-box-sizing(border-box);
border: 1px solid #ccc;
+ border-radius: 0.1em;
+ padding-left: 1em;
+ vertical-align: middle;
}
&.oo-ui-widget-enabled {
--
To view, visit https://gerrit.wikimedia.org/r/242530
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieabb382f8ec4b65ea08331e59e424b73bf9fe597
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
