Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/242589
Change subject: Fix lots and lots of whitespace issues
......................................................................
Fix lots and lots of whitespace issues
Focus on newlines at the end of the file. Also some open brackets that
are on the next line. Many mistakes are rare and do not justify an own
patch.
Change-Id: I8045840daf2fe209bfb157f43166092c72e4b084
---
M WikibaseQualityExternalValidationHooks.php
M api/RunCrossCheck.php
M includes/CrossCheck/Comparer/DataValueComparer.php
M includes/CrossCheck/Comparer/DataValueComparerFactory.php
M includes/CrossCheck/Comparer/DispatchingDataValueComparer.php
M includes/CrossCheck/Comparer/EntityIdValueComparer.php
M includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php
M includes/CrossCheck/Comparer/MonolingualTextValueComparer.php
M includes/CrossCheck/Comparer/MultilingualTextValueComparer.php
M includes/CrossCheck/Comparer/QuantityValueComparer.php
M includes/CrossCheck/Comparer/StringComparer.php
M includes/CrossCheck/Comparer/StringValueComparer.php
M includes/CrossCheck/Comparer/TimeValueComparer.php
M includes/CrossCheck/CrossCheckInteractor.php
M includes/CrossCheck/CrossChecker.php
M includes/CrossCheck/ReferenceChecker.php
M includes/CrossCheck/Result/ComparisonResult.php
M includes/CrossCheck/Result/CrossCheckResult.php
M includes/CrossCheck/Result/CrossCheckResultList.php
M includes/CrossCheck/Result/ReferenceResult.php
M includes/CrossCheck/ValueParser/ComparativeValueParser.php
M includes/CrossCheck/ValueParser/MultilingualTextValueParser.php
M includes/CrossCheck/ValueParser/StringValueParser.php
M includes/DumpMetaInformation/DumpMetaInformation.php
M includes/DumpMetaInformation/DumpMetaInformationLookup.php
M includes/DumpMetaInformation/DumpMetaInformationStore.php
M includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php
M includes/ExternalDataRepo.php
M includes/ExternalValidationServices.php
M includes/Serializer/ComparisonResultSerializer.php
M includes/Serializer/CrossCheckResultListSerializer.php
M includes/Serializer/CrossCheckResultSerializer.php
M includes/Serializer/DumpMetaInformationSerializer.php
M includes/Serializer/IndexedTagsSerializer.php
M includes/Serializer/ReferenceResultSerializer.php
M includes/Serializer/SerializerFactory.php
M includes/UpdateExternalData/CsvImportSettings.php
M includes/UpdateExternalData/ExternalDataImporter.php
M specials/SpecialCrossCheck.php
M specials/SpecialExternalDbs.php
M tests/phpunit/CrossCheck/Comparer/DataValueComparerFactoryTest.php
M tests/phpunit/CrossCheck/Comparer/DataValueComparerTestBase.php
M tests/phpunit/CrossCheck/Comparer/DispatchingDataValueComparerTest.php
M tests/phpunit/CrossCheck/Comparer/EntityIdValueComparerTest.php
M tests/phpunit/CrossCheck/Comparer/GlobeCoordinateValueComparerTest.php
M tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php
M tests/phpunit/CrossCheck/Comparer/MultilingualTextValueComparerTest.php
M tests/phpunit/CrossCheck/Comparer/QuantityValueComparerTest.php
M tests/phpunit/CrossCheck/Comparer/StringComparerTest.php
M tests/phpunit/CrossCheck/Comparer/StringValueComparerTest.php
M tests/phpunit/CrossCheck/Comparer/TimeValueComparerTest.php
M tests/phpunit/CrossCheck/CrossCheckInteractorTest.php
M tests/phpunit/CrossCheck/CrossCheckerTest.php
M tests/phpunit/CrossCheck/ReferenceCheckerTest.php
M tests/phpunit/CrossCheck/Result/ComparisonResultTest.php
M tests/phpunit/CrossCheck/Result/CrossCheckResultListTest.php
M tests/phpunit/CrossCheck/Result/CrossCheckResultTest.php
M tests/phpunit/CrossCheck/Result/ReferenceResultTest.php
M tests/phpunit/CrossCheck/ValueParser/MultilingualTextValueParserTest.php
M tests/phpunit/CrossCheck/ValueParser/StringValueParserTest.php
M tests/phpunit/CrossCheck/ValueParser/ValueParserTestBase.php
M tests/phpunit/DumpMetaInformation/DumpMetaInformationTest.php
M tests/phpunit/DumpMetaInformation/SqlDumpMetaInformationRepoTest.php
M tests/phpunit/ExternalDataRepoTest.php
M tests/phpunit/ExternalValidationServicesTest.php
M tests/phpunit/Serializer/ComparisonResultSerializerTest.php
M tests/phpunit/Serializer/CrossCheckResultSerializerTest.php
M tests/phpunit/Serializer/DumpMetaInformationSerializerTest.php
M tests/phpunit/Serializer/ReferenceResultSerializerTest.php
M tests/phpunit/Serializer/SerializerFactoryTest.php
M tests/phpunit/Specials/SpecialCrossCheckTest.php
M tests/phpunit/Specials/SpecialExternalDbsTest.php
M tests/phpunit/UpdateExternalData/CsvImportSettingsTest.php
M tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php
74 files changed, 155 insertions(+), 127 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityExternalValidation
refs/changes/89/242589/1
diff --git a/WikibaseQualityExternalValidationHooks.php
b/WikibaseQualityExternalValidationHooks.php
index 42b26b0..420ca64 100755
--- a/WikibaseQualityExternalValidationHooks.php
+++ b/WikibaseQualityExternalValidationHooks.php
@@ -19,4 +19,5 @@
$paths[] = __DIR__ . '/tests/phpunit';
return true;
}
-}
\ No newline at end of file
+
+}
diff --git a/api/RunCrossCheck.php b/api/RunCrossCheck.php
index 831f42e..06b2651 100755
--- a/api/RunCrossCheck.php
+++ b/api/RunCrossCheck.php
@@ -226,4 +226,5 @@
'action=wbqevcrosscheck&claims=Q42$D8404CDA-25E4-4334-AF13-A3290BCD9C0F' =>
'apihelp-wbqevcrosscheck-examples-5'
);
}
+
}
diff --git a/includes/CrossCheck/Comparer/DataValueComparer.php
b/includes/CrossCheck/Comparer/DataValueComparer.php
index 6aaf0ec..da75ec1 100755
--- a/includes/CrossCheck/Comparer/DataValueComparer.php
+++ b/includes/CrossCheck/Comparer/DataValueComparer.php
@@ -29,4 +29,5 @@
* @return string (one of the status constants of ComparisonResult)
*/
public function compare( DataValue $value, DataValue $comparativeValue
);
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/Comparer/DataValueComparerFactory.php
b/includes/CrossCheck/Comparer/DataValueComparerFactory.php
index 36db6c2..858ceef 100755
--- a/includes/CrossCheck/Comparer/DataValueComparerFactory.php
+++ b/includes/CrossCheck/Comparer/DataValueComparerFactory.php
@@ -130,4 +130,5 @@
public function newTimeValueComparer() {
return new TimeValueComparer();
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/Comparer/DispatchingDataValueComparer.php
b/includes/CrossCheck/Comparer/DispatchingDataValueComparer.php
index d6cace7..3b94f43 100755
--- a/includes/CrossCheck/Comparer/DispatchingDataValueComparer.php
+++ b/includes/CrossCheck/Comparer/DispatchingDataValueComparer.php
@@ -71,4 +71,5 @@
'None of the DataValueComparers can compare the
provided DataValue'
);
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/Comparer/EntityIdValueComparer.php
b/includes/CrossCheck/Comparer/EntityIdValueComparer.php
index e7e7ccd..96716a3 100755
--- a/includes/CrossCheck/Comparer/EntityIdValueComparer.php
+++ b/includes/CrossCheck/Comparer/EntityIdValueComparer.php
@@ -91,4 +91,5 @@
public function canCompare( DataValue $value, DataValue
$comparativeValue ) {
return $value instanceof EntityIdValue && $comparativeValue
instanceof MonolingualTextValue;
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php
b/includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php
index 7ff3e46..41bba39 100755
--- a/includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php
+++ b/includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php
@@ -56,4 +56,5 @@
public function canCompare( DataValue $value, DataValue
$comparativeValue ) {
return $value instanceof GlobeCoordinateValue &&
$comparativeValue instanceof GlobeCoordinateValue;
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/Comparer/MonolingualTextValueComparer.php
b/includes/CrossCheck/Comparer/MonolingualTextValueComparer.php
index 0eb1d56..8a8425c 100755
--- a/includes/CrossCheck/Comparer/MonolingualTextValueComparer.php
+++ b/includes/CrossCheck/Comparer/MonolingualTextValueComparer.php
@@ -52,4 +52,5 @@
public function canCompare( DataValue $value, DataValue
$comparativeValue ) {
return $value instanceof MonolingualTextValue &&
$comparativeValue instanceof MonolingualTextValue;
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/Comparer/MultilingualTextValueComparer.php
b/includes/CrossCheck/Comparer/MultilingualTextValueComparer.php
index f789e45..dd2e69b 100755
--- a/includes/CrossCheck/Comparer/MultilingualTextValueComparer.php
+++ b/includes/CrossCheck/Comparer/MultilingualTextValueComparer.php
@@ -73,4 +73,5 @@
public function canCompare( DataValue $value, DataValue
$comparativeValue ) {
return $value instanceof MultilingualTextValue &&
$comparativeValue instanceof MultilingualTextValue;
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/Comparer/QuantityValueComparer.php
b/includes/CrossCheck/Comparer/QuantityValueComparer.php
index cb5e7f6..e83a89b 100755
--- a/includes/CrossCheck/Comparer/QuantityValueComparer.php
+++ b/includes/CrossCheck/Comparer/QuantityValueComparer.php
@@ -45,4 +45,5 @@
public function canCompare( DataValue $value, DataValue
$comparativeValue ) {
return $value instanceof QuantityValue && $comparativeValue
instanceof QuantityValue;
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/Comparer/StringComparer.php
b/includes/CrossCheck/Comparer/StringComparer.php
index 21ead87..fd73e75 100755
--- a/includes/CrossCheck/Comparer/StringComparer.php
+++ b/includes/CrossCheck/Comparer/StringComparer.php
@@ -181,4 +181,5 @@
return $percentage;
}
+
}
diff --git a/includes/CrossCheck/Comparer/StringValueComparer.php
b/includes/CrossCheck/Comparer/StringValueComparer.php
index bcb9449..35e9c3e 100755
--- a/includes/CrossCheck/Comparer/StringValueComparer.php
+++ b/includes/CrossCheck/Comparer/StringValueComparer.php
@@ -50,4 +50,5 @@
public function canCompare( DataValue $value, DataValue
$comparativeValue ) {
return $value instanceof StringValue && $comparativeValue
instanceof StringValue;
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/Comparer/TimeValueComparer.php
b/includes/CrossCheck/Comparer/TimeValueComparer.php
index a047799..5825920 100755
--- a/includes/CrossCheck/Comparer/TimeValueComparer.php
+++ b/includes/CrossCheck/Comparer/TimeValueComparer.php
@@ -127,4 +127,5 @@
public function canCompare( DataValue $value, DataValue
$comparativeValue ) {
return $value instanceof TimeValue && $comparativeValue
instanceof TimeValue;
}
+
}
diff --git a/includes/CrossCheck/CrossCheckInteractor.php
b/includes/CrossCheck/CrossCheckInteractor.php
index 1f0e29f..effbfa5 100755
--- a/includes/CrossCheck/CrossCheckInteractor.php
+++ b/includes/CrossCheck/CrossCheckInteractor.php
@@ -300,4 +300,5 @@
}
}
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/CrossChecker.php
b/includes/CrossCheck/CrossChecker.php
index bfa2765..def22ec 100755
--- a/includes/CrossCheck/CrossChecker.php
+++ b/includes/CrossCheck/CrossChecker.php
@@ -380,4 +380,5 @@
return $dataValues;
}
+
}
diff --git a/includes/CrossCheck/ReferenceChecker.php
b/includes/CrossCheck/ReferenceChecker.php
index 6ff5218..336a61d 100755
--- a/includes/CrossCheck/ReferenceChecker.php
+++ b/includes/CrossCheck/ReferenceChecker.php
@@ -75,4 +75,5 @@
)
);
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/Result/ComparisonResult.php
b/includes/CrossCheck/Result/ComparisonResult.php
index 38f6526..b4142e6 100755
--- a/includes/CrossCheck/Result/ComparisonResult.php
+++ b/includes/CrossCheck/Result/ComparisonResult.php
@@ -91,4 +91,5 @@
$this->status = $status;
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/Result/CrossCheckResult.php
b/includes/CrossCheck/Result/CrossCheckResult.php
index afa7d48..d7e6629 100755
--- a/includes/CrossCheck/Result/CrossCheckResult.php
+++ b/includes/CrossCheck/Result/CrossCheckResult.php
@@ -123,4 +123,5 @@
public function getReferenceResult() {
return $this->referenceResult;
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/Result/CrossCheckResultList.php
b/includes/CrossCheck/Result/CrossCheckResultList.php
index 93fe9fd..a04834a 100755
--- a/includes/CrossCheck/Result/CrossCheckResultList.php
+++ b/includes/CrossCheck/Result/CrossCheckResultList.php
@@ -118,4 +118,5 @@
public function count() {
return count( $this->results );
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/Result/ReferenceResult.php
b/includes/CrossCheck/Result/ReferenceResult.php
index 68767b5..845c60a 100755
--- a/includes/CrossCheck/Result/ReferenceResult.php
+++ b/includes/CrossCheck/Result/ReferenceResult.php
@@ -73,4 +73,5 @@
$this->status = $status;
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/ValueParser/ComparativeValueParser.php
b/includes/CrossCheck/ValueParser/ComparativeValueParser.php
index 4d22606..01bd6f4 100644
--- a/includes/CrossCheck/ValueParser/ComparativeValueParser.php
+++ b/includes/CrossCheck/ValueParser/ComparativeValueParser.php
@@ -86,4 +86,5 @@
return $options;
}
+
}
diff --git a/includes/CrossCheck/ValueParser/MultilingualTextValueParser.php
b/includes/CrossCheck/ValueParser/MultilingualTextValueParser.php
index 7dab94f..96653d6 100644
--- a/includes/CrossCheck/ValueParser/MultilingualTextValueParser.php
+++ b/includes/CrossCheck/ValueParser/MultilingualTextValueParser.php
@@ -39,4 +39,5 @@
array( $this->monolingualTextValueParser->parse( $value
) )
);
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/CrossCheck/ValueParser/StringValueParser.php
b/includes/CrossCheck/ValueParser/StringValueParser.php
index 63c2b5b..dc499f4 100644
--- a/includes/CrossCheck/ValueParser/StringValueParser.php
+++ b/includes/CrossCheck/ValueParser/StringValueParser.php
@@ -33,4 +33,5 @@
return new StringValue( $this->stringNormalizer->trimToNFC(
$value ) );
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/DumpMetaInformation/DumpMetaInformation.php
b/includes/DumpMetaInformation/DumpMetaInformation.php
index 14b3245..57ac420 100755
--- a/includes/DumpMetaInformation/DumpMetaInformation.php
+++ b/includes/DumpMetaInformation/DumpMetaInformation.php
@@ -228,4 +228,5 @@
$this->size = $size;
}
+
}
diff --git a/includes/DumpMetaInformation/DumpMetaInformationLookup.php
b/includes/DumpMetaInformation/DumpMetaInformationLookup.php
index 12b9505..a964ef2 100644
--- a/includes/DumpMetaInformation/DumpMetaInformationLookup.php
+++ b/includes/DumpMetaInformation/DumpMetaInformationLookup.php
@@ -56,4 +56,5 @@
* @return DumpMetaInformation[]
*/
public function getAll();
-}
\ No newline at end of file
+
+}
diff --git a/includes/DumpMetaInformation/DumpMetaInformationStore.php
b/includes/DumpMetaInformation/DumpMetaInformationStore.php
index 350de1f..e14a3f8 100644
--- a/includes/DumpMetaInformation/DumpMetaInformationStore.php
+++ b/includes/DumpMetaInformation/DumpMetaInformationStore.php
@@ -16,4 +16,5 @@
* @param DumpMetaInformation $dumpMetaInformation
*/
public function save( DumpMetaInformation $dumpMetaInformation );
-}
\ No newline at end of file
+
+}
diff --git a/includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php
b/includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php
index 1aad2e5..3e6dd23 100755
--- a/includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php
+++ b/includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php
@@ -282,4 +282,5 @@
'license_qid' =>
$dumpMetaInformation->getLicenseItemId()->getSerialization()
);
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/ExternalDataRepo.php b/includes/ExternalDataRepo.php
index 47f1f29..2aa0c61 100755
--- a/includes/ExternalDataRepo.php
+++ b/includes/ExternalDataRepo.php
@@ -135,4 +135,5 @@
} while ( $db->affectedRows() > 0 );
}
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/ExternalValidationServices.php
b/includes/ExternalValidationServices.php
index f3d0981..8b047fc 100755
--- a/includes/ExternalValidationServices.php
+++ b/includes/ExternalValidationServices.php
@@ -20,8 +20,7 @@
* @author BP2014N1
* @license GNU GPL v2+
*/
-class ExternalValidationServices
-{
+class ExternalValidationServices {
/**
* @var WikibaseRepo
@@ -83,8 +82,7 @@
*
* @return ExternalValidationServices
*/
- public static function getDefaultInstance()
- {
+ public static function getDefaultInstance() {
static $instance = null;
if ($instance === null) {
@@ -99,8 +97,7 @@
/**
* @return CrossChecker
*/
- public function getCrossChecker()
- {
+ public function getCrossChecker() {
if ($this->crossChecker === null) {
$this->crossChecker = new CrossChecker(
$this->wikibaseRepo->getEntityLookup(),
@@ -118,8 +115,7 @@
/**
* @return CrossCheckInteractor
*/
- public function getCrossCheckInteractor()
- {
+ public function getCrossCheckInteractor() {
if ($this->crossCheckInteractor === null) {
$this->crossCheckInteractor = new CrossCheckInteractor(
$this->wikibaseRepo->getEntityLookup(),
@@ -133,8 +129,7 @@
/**
* @return ComparativeValueParserFactory
*/
- public function getComparativeValueParserFactory()
- {
+ public function getComparativeValueParserFactory() {
if ($this->comparativeValueParserFactory === null) {
$this->comparativeValueParserFactory = new
ComparativeValueParserFactory(
$this->wikibaseRepo->getDataTypeDefinitions(),
@@ -148,8 +143,7 @@
/**
* @return DataValueComparerFactory
*/
- public function getDataValueComparerFactory()
- {
+ public function getDataValueComparerFactory() {
if ($this->dataValueComparerFactory === null) {
$this->dataValueComparerFactory = new
DataValueComparerFactory(
$this->wikibaseRepo->getStore()->getTermIndex(),
@@ -163,8 +157,7 @@
/**
* @return DumpMetaInformationLookup
*/
- public function getDumpMetaInformationLookup()
- {
+ public function getDumpMetaInformationLookup() {
if ($this->dumpMetaInformationLookup === null) {
$this->dumpMetaInformationLookup = new
SqlDumpMetaInformationRepo();
}
@@ -175,8 +168,7 @@
/**
* @return DumpMetaInformationStore
*/
- public function getDumpMetaInformationStore()
- {
+ public function getDumpMetaInformationStore() {
if ($this->dumpMetaInformationStore === null) {
$this->dumpMetaInformationStore = new
SqlDumpMetaInformationRepo();
}
@@ -187,8 +179,7 @@
/**
* @return ExternalDataRepo
*/
- public function getExternalDataRepo()
- {
+ public function getExternalDataRepo() {
if ($this->externalDataRepo === null) {
$this->externalDataRepo = new ExternalDataRepo();
}
@@ -199,8 +190,7 @@
/**
* @return SerializerFactory
*/
- public function getSerializerFactory()
- {
+ public function getSerializerFactory() {
if ($this->serializerFactory === null) {
$dataValueSerializer = new DataValueSerializer();
$dataModelSerializerFactory = new
\Wikibase\DataModel\SerializerFactory($dataValueSerializer);
diff --git a/includes/Serializer/ComparisonResultSerializer.php
b/includes/Serializer/ComparisonResultSerializer.php
index 938724b..dcd3bd8 100755
--- a/includes/Serializer/ComparisonResultSerializer.php
+++ b/includes/Serializer/ComparisonResultSerializer.php
@@ -72,4 +72,5 @@
'result' => $comparisonResult->getStatus()
);
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/Serializer/CrossCheckResultListSerializer.php
b/includes/Serializer/CrossCheckResultListSerializer.php
index a0ecd4e..7ff1921 100755
--- a/includes/Serializer/CrossCheckResultListSerializer.php
+++ b/includes/Serializer/CrossCheckResultListSerializer.php
@@ -76,4 +76,4 @@
return $serialization;
}
-}
\ No newline at end of file
+}
diff --git a/includes/Serializer/CrossCheckResultSerializer.php
b/includes/Serializer/CrossCheckResultSerializer.php
index 5c166d6..e52330e 100755
--- a/includes/Serializer/CrossCheckResultSerializer.php
+++ b/includes/Serializer/CrossCheckResultSerializer.php
@@ -80,4 +80,5 @@
'referenceResult' =>
$this->referenceResultSerializer->serialize(
$crossCheckResult->getReferenceResult() )
);
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/Serializer/DumpMetaInformationSerializer.php
b/includes/Serializer/DumpMetaInformationSerializer.php
index 935b55a..e0102eb 100755
--- a/includes/Serializer/DumpMetaInformationSerializer.php
+++ b/includes/Serializer/DumpMetaInformationSerializer.php
@@ -65,4 +65,5 @@
'licenseItemId' =>
$dumpMetaInformation->getLicenseItemId()->getSerialization()
);
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/Serializer/IndexedTagsSerializer.php
b/includes/Serializer/IndexedTagsSerializer.php
index e18bd95..339093f 100755
--- a/includes/Serializer/IndexedTagsSerializer.php
+++ b/includes/Serializer/IndexedTagsSerializer.php
@@ -38,4 +38,4 @@
ApiResult::setIndexedTagName( $arr, $tagName );
}
-}
\ No newline at end of file
+}
diff --git a/includes/Serializer/ReferenceResultSerializer.php
b/includes/Serializer/ReferenceResultSerializer.php
index 9323759..5448a28 100755
--- a/includes/Serializer/ReferenceResultSerializer.php
+++ b/includes/Serializer/ReferenceResultSerializer.php
@@ -62,4 +62,5 @@
'status' => $referenceResult->getStatus()
);
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/Serializer/SerializerFactory.php
b/includes/Serializer/SerializerFactory.php
index 4758880..c09466b 100755
--- a/includes/Serializer/SerializerFactory.php
+++ b/includes/Serializer/SerializerFactory.php
@@ -80,4 +80,5 @@
public function newReferenceResultSerializer() {
return new ReferenceResultSerializer(
$this->referenceSerializer );
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/UpdateExternalData/CsvImportSettings.php
b/includes/UpdateExternalData/CsvImportSettings.php
index 663c244..b1357e6 100755
--- a/includes/UpdateExternalData/CsvImportSettings.php
+++ b/includes/UpdateExternalData/CsvImportSettings.php
@@ -82,4 +82,5 @@
public function isQuiet() {
return $this->quiet;
}
-}
\ No newline at end of file
+
+}
diff --git a/includes/UpdateExternalData/ExternalDataImporter.php
b/includes/UpdateExternalData/ExternalDataImporter.php
index 354efd4..ea46cf1 100755
--- a/includes/UpdateExternalData/ExternalDataImporter.php
+++ b/includes/UpdateExternalData/ExternalDataImporter.php
@@ -170,4 +170,5 @@
print $text;
}
}
-}
\ No newline at end of file
+
+}
diff --git a/specials/SpecialCrossCheck.php b/specials/SpecialCrossCheck.php
index faa2773..c13294c 100755
--- a/specials/SpecialCrossCheck.php
+++ b/specials/SpecialCrossCheck.php
@@ -34,8 +34,7 @@
use WikibaseQuality\Html\HtmlTableCellBuilder;
use WikibaseQuality\Html\HtmlTableHeaderBuilder;
-class SpecialCrossCheck extends SpecialPage
-{
+class SpecialCrossCheck extends SpecialPage {
/**
* @var EntityIdParser
@@ -71,8 +70,7 @@
* Creates new instance from global state.
* @return SpecialCrossCheck
*/
- public static function newFromGlobalState()
- {
+ public static function newFromGlobalState() {
$repo = WikibaseRepo::getDefaultInstance();
$externalValidationServices =
ExternalValidationServices::getDefaultInstance();
@@ -95,7 +93,6 @@
* @param EntityTitleLookup $entityTitleLookup
* @param CrossCheckInteractor $checkInteractor
*/
-
public function __construct(
EntityLookup $entityLookup,
TermLookup $termLookup,
@@ -104,8 +101,7 @@
EntityIdParser $entityIdParser,
OutputFormatValueFormatterFactory $valueFormatterFactory,
CrossCheckInteractor $crossCheckInteractor
- )
- {
+ ) {
parent::__construct('CrossCheck');
$this->entityLookup = $entityLookup;
@@ -127,8 +123,7 @@
*
* @return string
*/
- public function getGroupName()
- {
+ public function getGroupName() {
return 'wikibasequality';
}
@@ -137,8 +132,7 @@
*
* @return string (plain text)
*/
- public function getDescription()
- {
+ public function getDescription() {
return $this->msg('wbqev-crosscheck')->text();
}
@@ -151,8 +145,7 @@
* @throws EntityIdParsingException
* @throws UnexpectedValueException
*/
- public function execute($subPage)
- {
+ public function execute( $subPage ) {
$out = $this->getOutput();
$postRequest =
$this->getContext()->getRequest()->getVal('entityid');
if ($postRequest) {
@@ -205,8 +198,7 @@
/**
* Builds html form for entity id input
*/
- private function buildEntityIdForm()
- {
+ private function buildEntityIdForm() {
$formDescriptor = array(
'entityid' => array(
'class' => 'HTMLTextField',
@@ -231,8 +223,7 @@
*
* @return string HTML
*/
- private function buildInfoBox()
- {
+ private function buildInfoBox() {
$externalDbLink = Linker::specialLink('ExternalDbs',
'wbqev-externaldbs');
$infoBox =
Html::openElement(
@@ -282,8 +273,7 @@
*
* @return string HTML
*/
- private function buildResultHeader(EntityId $entityId)
- {
+ private function buildResultHeader( EntityId $entityId ) {
$entityLink = sprintf('%s (%s)',
$this->entityIdLinkFormatter->formatEntityId($entityId),
htmlspecialchars($entityId->getSerialization()));
@@ -303,8 +293,7 @@
*
* @return string HTML
*/
- private function buildSummary($results)
- {
+ private function buildSummary( $results ) {
$statuses = array();
foreach ($results as $result) {
$status =
strtolower($result->getComparisonResult()->getStatus());
@@ -397,8 +386,7 @@
*
* @return string HTML
*/
- private function buildResultTable($results)
- {
+ private function buildResultTable( $results ) {
$table = new HtmlTableBuilder(
array(
new HtmlTableHeaderBuilder(
diff --git a/specials/SpecialExternalDbs.php b/specials/SpecialExternalDbs.php
index 6b290e7..7d62bbb 100755
--- a/specials/SpecialExternalDbs.php
+++ b/specials/SpecialExternalDbs.php
@@ -179,4 +179,5 @@
return $rows;
}
+
}
diff --git a/tests/phpunit/CrossCheck/Comparer/DataValueComparerFactoryTest.php
b/tests/phpunit/CrossCheck/Comparer/DataValueComparerFactoryTest.php
index b59dd1f..d2a3522 100755
--- a/tests/phpunit/CrossCheck/Comparer/DataValueComparerFactoryTest.php
+++ b/tests/phpunit/CrossCheck/Comparer/DataValueComparerFactoryTest.php
@@ -194,4 +194,5 @@
$this->assertStringValueComparesWithoutException(
$dataValueComparer );
$this->assertTimeValueComparesWithoutException(
$dataValueComparer );
}
+
}
diff --git a/tests/phpunit/CrossCheck/Comparer/DataValueComparerTestBase.php
b/tests/phpunit/CrossCheck/Comparer/DataValueComparerTestBase.php
index 311e3c3..a7799b0 100755
--- a/tests/phpunit/CrossCheck/Comparer/DataValueComparerTestBase.php
+++ b/tests/phpunit/CrossCheck/Comparer/DataValueComparerTestBase.php
@@ -61,4 +61,5 @@
}
public abstract function comparisonProvider();
-}
\ No newline at end of file
+
+}
diff --git
a/tests/phpunit/CrossCheck/Comparer/DispatchingDataValueComparerTest.php
b/tests/phpunit/CrossCheck/Comparer/DispatchingDataValueComparerTest.php
index 94b6217..a5b2765 100755
--- a/tests/phpunit/CrossCheck/Comparer/DispatchingDataValueComparerTest.php
+++ b/tests/phpunit/CrossCheck/Comparer/DispatchingDataValueComparerTest.php
@@ -155,4 +155,5 @@
)
);
}
+
}
diff --git a/tests/phpunit/CrossCheck/Comparer/EntityIdValueComparerTest.php
b/tests/phpunit/CrossCheck/Comparer/EntityIdValueComparerTest.php
index 20637f0..6827a47 100755
--- a/tests/phpunit/CrossCheck/Comparer/EntityIdValueComparerTest.php
+++ b/tests/phpunit/CrossCheck/Comparer/EntityIdValueComparerTest.php
@@ -142,4 +142,5 @@
return new EntityIdValueComparer( $termIndex, $stringComparer );
}
-}
\ No newline at end of file
+
+}
diff --git
a/tests/phpunit/CrossCheck/Comparer/GlobeCoordinateValueComparerTest.php
b/tests/phpunit/CrossCheck/Comparer/GlobeCoordinateValueComparerTest.php
index 6f9d6fd..c61d0bc 100755
--- a/tests/phpunit/CrossCheck/Comparer/GlobeCoordinateValueComparerTest.php
+++ b/tests/phpunit/CrossCheck/Comparer/GlobeCoordinateValueComparerTest.php
@@ -93,4 +93,5 @@
protected function buildComparer() {
return new GlobeCoordinateValueComparer();
}
-}
\ No newline at end of file
+
+}
diff --git
a/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php
b/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php
index 9fd012d..3b08aae 100755
--- a/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php
+++ b/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php
@@ -91,4 +91,5 @@
return new MonolingualTextValueComparer( $stringComparer );
}
-}
\ No newline at end of file
+
+}
diff --git
a/tests/phpunit/CrossCheck/Comparer/MultilingualTextValueComparerTest.php
b/tests/phpunit/CrossCheck/Comparer/MultilingualTextValueComparerTest.php
index a096459..a041853 100755
--- a/tests/phpunit/CrossCheck/Comparer/MultilingualTextValueComparerTest.php
+++ b/tests/phpunit/CrossCheck/Comparer/MultilingualTextValueComparerTest.php
@@ -147,4 +147,5 @@
return new MultilingualTextValueComparer( $stringComparer );
}
-}
\ No newline at end of file
+
+}
diff --git a/tests/phpunit/CrossCheck/Comparer/QuantityValueComparerTest.php
b/tests/phpunit/CrossCheck/Comparer/QuantityValueComparerTest.php
index 0edfda5..5c67bd3 100755
--- a/tests/phpunit/CrossCheck/Comparer/QuantityValueComparerTest.php
+++ b/tests/phpunit/CrossCheck/Comparer/QuantityValueComparerTest.php
@@ -82,4 +82,5 @@
protected function buildComparer() {
return new QuantityValueComparer();
}
-}
\ No newline at end of file
+
+}
diff --git a/tests/phpunit/CrossCheck/Comparer/StringComparerTest.php
b/tests/phpunit/CrossCheck/Comparer/StringComparerTest.php
index 0eac54a..ae08a15 100755
--- a/tests/phpunit/CrossCheck/Comparer/StringComparerTest.php
+++ b/tests/phpunit/CrossCheck/Comparer/StringComparerTest.php
@@ -307,4 +307,5 @@
)
);
}
+
}
diff --git a/tests/phpunit/CrossCheck/Comparer/StringValueComparerTest.php
b/tests/phpunit/CrossCheck/Comparer/StringValueComparerTest.php
index 9aeb9ae..c751118 100755
--- a/tests/phpunit/CrossCheck/Comparer/StringValueComparerTest.php
+++ b/tests/phpunit/CrossCheck/Comparer/StringValueComparerTest.php
@@ -85,4 +85,5 @@
return new StringValueComparer( $stringComparer );
}
-}
\ No newline at end of file
+
+}
diff --git a/tests/phpunit/CrossCheck/Comparer/TimeValueComparerTest.php
b/tests/phpunit/CrossCheck/Comparer/TimeValueComparerTest.php
index 0fd59fc..b4050c4 100755
--- a/tests/phpunit/CrossCheck/Comparer/TimeValueComparerTest.php
+++ b/tests/phpunit/CrossCheck/Comparer/TimeValueComparerTest.php
@@ -93,4 +93,5 @@
protected function buildComparer() {
return new TimeValueComparer();
}
+
}
diff --git a/tests/phpunit/CrossCheck/CrossCheckInteractorTest.php
b/tests/phpunit/CrossCheck/CrossCheckInteractorTest.php
index 251235b..662be47 100755
--- a/tests/phpunit/CrossCheck/CrossCheckInteractorTest.php
+++ b/tests/phpunit/CrossCheck/CrossCheckInteractorTest.php
@@ -741,4 +741,5 @@
$this->assertNull( $actualResult );
}
}
+
}
diff --git a/tests/phpunit/CrossCheck/CrossCheckerTest.php
b/tests/phpunit/CrossCheck/CrossCheckerTest.php
index ce6a77b..84809fb 100755
--- a/tests/phpunit/CrossCheck/CrossCheckerTest.php
+++ b/tests/phpunit/CrossCheck/CrossCheckerTest.php
@@ -392,4 +392,5 @@
return $externalDataRepo;
}
-}
\ No newline at end of file
+
+}
diff --git a/tests/phpunit/CrossCheck/ReferenceCheckerTest.php
b/tests/phpunit/CrossCheck/ReferenceCheckerTest.php
index 7f11f5e..16bd4ba 100755
--- a/tests/phpunit/CrossCheck/ReferenceCheckerTest.php
+++ b/tests/phpunit/CrossCheck/ReferenceCheckerTest.php
@@ -140,4 +140,5 @@
return $mock;
}
+
}
diff --git a/tests/phpunit/CrossCheck/Result/ComparisonResultTest.php
b/tests/phpunit/CrossCheck/Result/ComparisonResultTest.php
index c66569d..0bb19b7 100755
--- a/tests/phpunit/CrossCheck/Result/ComparisonResultTest.php
+++ b/tests/phpunit/CrossCheck/Result/ComparisonResultTest.php
@@ -85,5 +85,5 @@
)
);
}
+
}
-
\ No newline at end of file
diff --git a/tests/phpunit/CrossCheck/Result/CrossCheckResultListTest.php
b/tests/phpunit/CrossCheck/Result/CrossCheckResultListTest.php
index 8217e49..0fde3d0 100755
--- a/tests/phpunit/CrossCheck/Result/CrossCheckResultListTest.php
+++ b/tests/phpunit/CrossCheck/Result/CrossCheckResultListTest.php
@@ -16,6 +16,7 @@
* @license GNU GPL v2+
*/
class CrossCheckResultListTest extends \MediaWikiTestCase {
+
/**
* @var CrossCheckResult
*/
@@ -189,4 +190,5 @@
return $crossCheckResultMock;
}
-}
\ No newline at end of file
+
+}
diff --git a/tests/phpunit/CrossCheck/Result/CrossCheckResultTest.php
b/tests/phpunit/CrossCheck/Result/CrossCheckResultTest.php
index 7fb2041..807d0f4 100755
--- a/tests/phpunit/CrossCheck/Result/CrossCheckResultTest.php
+++ b/tests/phpunit/CrossCheck/Result/CrossCheckResultTest.php
@@ -118,4 +118,5 @@
return $mock;
}
+
}
diff --git a/tests/phpunit/CrossCheck/Result/ReferenceResultTest.php
b/tests/phpunit/CrossCheck/Result/ReferenceResultTest.php
index cbe4b52..c98c531 100755
--- a/tests/phpunit/CrossCheck/Result/ReferenceResultTest.php
+++ b/tests/phpunit/CrossCheck/Result/ReferenceResultTest.php
@@ -70,5 +70,5 @@
)
);
}
+
}
-
\ No newline at end of file
diff --git
a/tests/phpunit/CrossCheck/ValueParser/MultilingualTextValueParserTest.php
b/tests/phpunit/CrossCheck/ValueParser/MultilingualTextValueParserTest.php
index 4eef5c9..332f2a1 100644
--- a/tests/phpunit/CrossCheck/ValueParser/MultilingualTextValueParserTest.php
+++ b/tests/phpunit/CrossCheck/ValueParser/MultilingualTextValueParserTest.php
@@ -50,4 +50,5 @@
return new MultilingualTextValueParser( $valueParserMock );
}
+
}
diff --git a/tests/phpunit/CrossCheck/ValueParser/StringValueParserTest.php
b/tests/phpunit/CrossCheck/ValueParser/StringValueParserTest.php
index 1b24ba9..d6c539c 100644
--- a/tests/phpunit/CrossCheck/ValueParser/StringValueParserTest.php
+++ b/tests/phpunit/CrossCheck/ValueParser/StringValueParserTest.php
@@ -49,4 +49,5 @@
return new StringValueParser( $stringNormalizer );
}
+
}
diff --git a/tests/phpunit/CrossCheck/ValueParser/ValueParserTestBase.php
b/tests/phpunit/CrossCheck/ValueParser/ValueParserTestBase.php
index 8a90bf7..fcf27be 100755
--- a/tests/phpunit/CrossCheck/ValueParser/ValueParserTestBase.php
+++ b/tests/phpunit/CrossCheck/ValueParser/ValueParserTestBase.php
@@ -41,4 +41,5 @@
$this->assertEquals( $expectedResult, $actualResult );
}
-}
\ No newline at end of file
+
+}
diff --git a/tests/phpunit/DumpMetaInformation/DumpMetaInformationTest.php
b/tests/phpunit/DumpMetaInformation/DumpMetaInformationTest.php
index 6b4e844..12f5544 100755
--- a/tests/phpunit/DumpMetaInformation/DumpMetaInformationTest.php
+++ b/tests/phpunit/DumpMetaInformation/DumpMetaInformationTest.php
@@ -185,5 +185,5 @@
$this->assertEquals(
$this->dumpMetaInformation->getLicenseItemId(), new ItemId( 'Q6938433' ) );
}
+
}
-
\ No newline at end of file
diff --git
a/tests/phpunit/DumpMetaInformation/SqlDumpMetaInformationRepoTest.php
b/tests/phpunit/DumpMetaInformation/SqlDumpMetaInformationRepoTest.php
index 51a5340..19b3870 100755
--- a/tests/phpunit/DumpMetaInformation/SqlDumpMetaInformationRepoTest.php
+++ b/tests/phpunit/DumpMetaInformation/SqlDumpMetaInformationRepoTest.php
@@ -357,4 +357,5 @@
)
);
}
+
}
diff --git a/tests/phpunit/ExternalDataRepoTest.php
b/tests/phpunit/ExternalDataRepoTest.php
index ae02413..742387c 100755
--- a/tests/phpunit/ExternalDataRepoTest.php
+++ b/tests/phpunit/ExternalDataRepoTest.php
@@ -363,4 +363,5 @@
)
);
}
-}
\ No newline at end of file
+
+}
diff --git a/tests/phpunit/ExternalValidationServicesTest.php
b/tests/phpunit/ExternalValidationServicesTest.php
index e6435f7..9b85461 100755
--- a/tests/phpunit/ExternalValidationServicesTest.php
+++ b/tests/phpunit/ExternalValidationServicesTest.php
@@ -13,19 +13,16 @@
* @author BP2014N1
* @license GNU GPL v2+
*/
-class ExternalValidationServicesTest extends \MediaWikiTestCase
-{
+class ExternalValidationServicesTest extends \MediaWikiTestCase {
- public function testGetDefaultInstance()
- {
+ public function testGetDefaultInstance() {
$this->assertInstanceOf(
'WikibaseQuality\ExternalValidation\ExternalValidationServices',
ExternalValidationServices::getDefaultInstance()
);
}
- public function testGetCrossChecker()
- {
+ public function testGetCrossChecker() {
$crossChecker = $this->getFactory()->getCrossChecker();
$this->assertInstanceOf(
@@ -34,8 +31,7 @@
);
}
- public function testGetCrossCheckInteractor()
- {
+ public function testGetCrossCheckInteractor() {
$crossCheckInteractor =
$this->getFactory()->getCrossCheckInteractor();
$this->assertInstanceOf(
@@ -44,8 +40,7 @@
);
}
- public function testGetDataValueComparerFactory()
- {
+ public function testGetDataValueComparerFactory() {
$dataValueComparerFactory =
$this->getFactory()->getDataValueComparerFactory();
$this->assertInstanceOf(
@@ -54,8 +49,7 @@
);
}
- public function testGetDumpMetaInformationLookup()
- {
+ public function testGetDumpMetaInformationLookup() {
$dumpMetaInformationRepo =
$this->getFactory()->getDumpMetaInformationLookup();
$this->assertInstanceOf(
@@ -64,8 +58,7 @@
);
}
- public function testGetDumpMetaInformationStore()
- {
+ public function testGetDumpMetaInformationStore() {
$dumpMetaInformationRepo =
$this->getFactory()->getDumpMetaInformationStore();
$this->assertInstanceOf(
@@ -74,8 +67,7 @@
);
}
- public function testGetSerializerFactory()
- {
+ public function testGetSerializerFactory() {
$serializerFactory =
$this->getFactory()->getSerializerFactory();
$this->assertInstanceOf(
@@ -84,11 +76,11 @@
);
}
- private function getFactory()
- {
+ private function getFactory() {
return new ExternalValidationServices(
WikibaseRepo::getDefaultInstance(),
$this->getMockBuilder('Wikibase\Repo\ValueParserFactory')->disableOriginalConstructor()->getMock()
);
}
+
}
diff --git a/tests/phpunit/Serializer/ComparisonResultSerializerTest.php
b/tests/phpunit/Serializer/ComparisonResultSerializerTest.php
index 49282f8..58a0951 100755
--- a/tests/phpunit/Serializer/ComparisonResultSerializerTest.php
+++ b/tests/phpunit/Serializer/ComparisonResultSerializerTest.php
@@ -239,4 +239,5 @@
return new ComparisonResultSerializer( $serializerMock );
}
+
}
diff --git a/tests/phpunit/Serializer/CrossCheckResultSerializerTest.php
b/tests/phpunit/Serializer/CrossCheckResultSerializerTest.php
index fa0a40a..bc910f9 100755
--- a/tests/phpunit/Serializer/CrossCheckResultSerializerTest.php
+++ b/tests/phpunit/Serializer/CrossCheckResultSerializerTest.php
@@ -131,4 +131,5 @@
private function getMockWithoutConstructor( $className ) {
return $this->getMockBuilder( $className
)->disableOriginalConstructor()->getMock();
}
+
}
diff --git a/tests/phpunit/Serializer/DumpMetaInformationSerializerTest.php
b/tests/phpunit/Serializer/DumpMetaInformationSerializerTest.php
index c2707d4..35541e7 100755
--- a/tests/phpunit/Serializer/DumpMetaInformationSerializerTest.php
+++ b/tests/phpunit/Serializer/DumpMetaInformationSerializerTest.php
@@ -148,4 +148,4 @@
);
}
-}
\ No newline at end of file
+}
diff --git a/tests/phpunit/Serializer/ReferenceResultSerializerTest.php
b/tests/phpunit/Serializer/ReferenceResultSerializerTest.php
index cb1b1cc..cf309c5 100755
--- a/tests/phpunit/Serializer/ReferenceResultSerializerTest.php
+++ b/tests/phpunit/Serializer/ReferenceResultSerializerTest.php
@@ -112,4 +112,5 @@
return new ReferenceResultSerializer( $serializerMock );
}
+
}
diff --git a/tests/phpunit/Serializer/SerializerFactoryTest.php
b/tests/phpunit/Serializer/SerializerFactoryTest.php
index dae8db1..cc02230 100755
--- a/tests/phpunit/Serializer/SerializerFactoryTest.php
+++ b/tests/phpunit/Serializer/SerializerFactoryTest.php
@@ -142,4 +142,5 @@
$this->crossCheckResultList
);
}
-}
\ No newline at end of file
+
+}
diff --git a/tests/phpunit/Specials/SpecialCrossCheckTest.php
b/tests/phpunit/Specials/SpecialCrossCheckTest.php
index fc5d98c..0a2536f 100755
--- a/tests/phpunit/Specials/SpecialCrossCheckTest.php
+++ b/tests/phpunit/Specials/SpecialCrossCheckTest.php
@@ -45,8 +45,8 @@
* @author BP2014N1
* @license GNU GPL v2+
*/
-class SpecialCrossCheckTest extends SpecialPageTestBase
-{
+class SpecialCrossCheckTest extends SpecialPageTestBase {
+
/**
* Id of a item that (hopefully) does not exist.
*/
@@ -67,16 +67,14 @@
*/
private static $hasSetup;
- protected function setUp()
- {
+ protected function setUp() {
parent::setUp();
$this->tablesUsed[] =
SqlDumpMetaInformationRepo::META_TABLE_NAME;
$this->tablesUsed[] =
SqlDumpMetaInformationRepo::IDENTIFIER_PROPERTIES_TABLE_NAME;
$this->tablesUsed[] = ExternalDataRepo::TABLE_NAME;
}
- protected function newSpecialPage()
- {
+ protected function newSpecialPage() {
$externalValidationFactory =
ExternalValidationServices::getDefaultInstance();
$wikibaseRepo = WikibaseRepo::getDefaultInstance();
@@ -95,8 +93,7 @@
* Adds temporary test data to database
* @throws \DBUnexpectedError
*/
- public function addDBData()
- {
+ public function addDBData() {
if (!self::$hasSetup) {
$store =
WikibaseRepo::getDefaultInstance()->getEntityStore();
@@ -225,8 +222,7 @@
/**
* @dataProvider executeProvider
*/
- public function testExecute($subPage, $request, $userLanguage,
$matchers)
- {
+ public function testExecute( $subPage, $request, $userLanguage,
$matchers ) {
$request = new \FauxRequest($request);
// The added item is Q1. This solves the problem that the
provider is executed before the test
@@ -244,8 +240,7 @@
* Test cases for testExecute
* @return array
*/
- public function executeProvider()
- {
+ public function executeProvider() {
$userLanguage = 'qqx';
$cases = array();
$matchers = array();
@@ -426,4 +421,5 @@
return $cases;
}
+
}
diff --git a/tests/phpunit/Specials/SpecialExternalDbsTest.php
b/tests/phpunit/Specials/SpecialExternalDbsTest.php
index 1f74e9e..12f2bda 100755
--- a/tests/phpunit/Specials/SpecialExternalDbsTest.php
+++ b/tests/phpunit/Specials/SpecialExternalDbsTest.php
@@ -24,8 +24,7 @@
* @author BP2014N1
* @license GNU GPL v2+
*/
-class SpecialExternalDbsTest extends SpecialPageTestBase
-{
+class SpecialExternalDbsTest extends SpecialPageTestBase {
protected function setUp() {
parent::setUp();
@@ -49,8 +48,7 @@
* Adds temporary test data to database
* @throws \DBUnexpectedError
*/
- public function addDBData()
- {
+ public function addDBData() {
// Truncate table
$this->db->delete(
SqlDumpMetaInformationRepo::META_TABLE_NAME,
@@ -103,8 +101,7 @@
}
}
- public function executeProvider()
- {
+ public function executeProvider() {
$userLanguage = 'qqx';
$cases = array();
$matchers = array();
@@ -230,4 +227,5 @@
return $cases;
}
-}
\ No newline at end of file
+
+}
diff --git a/tests/phpunit/UpdateExternalData/CsvImportSettingsTest.php
b/tests/phpunit/UpdateExternalData/CsvImportSettingsTest.php
index c183599..c599051 100755
--- a/tests/phpunit/UpdateExternalData/CsvImportSettingsTest.php
+++ b/tests/phpunit/UpdateExternalData/CsvImportSettingsTest.php
@@ -57,4 +57,5 @@
)
);
}
+
}
diff --git a/tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php
b/tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php
index 5bbb667..920ef61 100755
--- a/tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php
+++ b/tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php
@@ -172,4 +172,5 @@
)
);
}
+
}
--
To view, visit https://gerrit.wikimedia.org/r/242589
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8045840daf2fe209bfb157f43166092c72e4b084
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
