Liangent has uploaded a new change for review.
https://gerrit.wikimedia.org/r/242584
Change subject: Fix accidential variable overriding in manualWordsTable
......................................................................
Fix accidential variable overriding in manualWordsTable
It doesn't make sense to get a table passed in then ignore that one
completely so it doesn't look like the intentional behavior, and
regardless of this, the edited code is still more logical.
Change-Id: I98bc841e982d328e268309c06fefd3d3ca9f6cd7
---
M maintenance/language/zhtable/Makefile.py
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/84/242584/1
diff --git a/maintenance/language/zhtable/Makefile.py
b/maintenance/language/zhtable/Makefile.py
index 4ab57d4..9d64a89 100755
--- a/maintenance/language/zhtable/Makefile.py
+++ b/maintenance/language/zhtable/Makefile.py
@@ -229,7 +229,7 @@
def manualWordsTable( path, conv_table, reconv_table ):
fp = open( path, 'r', encoding = 'U8' )
- reconv_table = {}
+ out_table = {}
wordlist = [line.split( '#' )[0].strip() for line in fp]
wordlist = list( set( wordlist ) )
wordlist.sort( key = lambda w: ( len(w), w ), reverse = True )
@@ -238,9 +238,9 @@
new_word = translate( word, conv_table )
rcv_word = translate( word, reconv_table )
if word != rcv_word:
- reconv_table[word] = word
- reconv_table[new_word] = word
- return reconv_table
+ out_table[word] = word
+ out_table[new_word] = word
+ return out_table
def defaultWordsTable( src_wordlist, src_tomany, char_conv_table,
char_reconv_table ):
wordlist = list( src_wordlist )
--
To view, visit https://gerrit.wikimedia.org/r/242584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98bc841e982d328e268309c06fefd3d3ca9f6cd7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Liangent <liang...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
