jenkins-bot has submitted this change and it was merged. Change subject: Don't call deprecated functions and load required modules ......................................................................
Don't call deprecated functions and load required modules Change-Id: If7e5fe1900a929fa6a71fb1d3817cf11257227e5 --- M CharInsert.body.php 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/CharInsert.body.php b/CharInsert.body.php index 46f8985..1702cf0 100644 --- a/CharInsert.body.php +++ b/CharInsert.body.php @@ -8,6 +8,8 @@ public static function charInsertHook( $data, $params, Parser $parser ) { $data = $parser->mStripState->unstripBoth( $data ); + // For mw.toolbar.insertTags() + $parser->getOutput()->addModules( 'mediawiki.toolbar' ); return implode( "<br />\n", array_map( 'CharInsert::charInsertLine', explode( "\n", trim( $data ) ) ) ); @@ -53,7 +55,7 @@ } return Xml::element( 'a', array( - 'onclick' => "insertTags('$estart','$eend','');return false", + 'onclick' => "mw.toolbar.insertTags('$estart','$eend','');return false", 'href' => "javascript:void()" ), $inline ); } -- To view, visit https://gerrit.wikimedia.org/r/242571 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7e5fe1900a929fa6a71fb1d3817cf11257227e5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CharInsert Gerrit-Branch: master Gerrit-Owner: Bartosz DziewoĆski <matma....@gmail.com> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits