Ejegg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/242732
Change subject: Throw exception on duplicate CSV header
......................................................................
Throw exception on duplicate CSV header
Change-Id: I70d572c89b1472913339275bf7d8e8ab1dbc6829
---
M Core/DataFiles/HeadedCsvReader.php
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig
refs/changes/32/242732/1
diff --git a/Core/DataFiles/HeadedCsvReader.php
b/Core/DataFiles/HeadedCsvReader.php
index bf0babb..24a198e 100644
--- a/Core/DataFiles/HeadedCsvReader.php
+++ b/Core/DataFiles/HeadedCsvReader.php
@@ -20,6 +20,9 @@
// Extract the header information
$this->colNames = parent::current();
foreach( $this->colNames as $index => $name ) {
+ if ( isset( $this->colIndexes[$name] ) ) {
+ throw new DataFileException( "Duplicate column
name {$name}!" );
+ }
$this->colIndexes[$name] = $index;
}
parent::next();
--
To view, visit https://gerrit.wikimedia.org/r/242732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70d572c89b1472913339275bf7d8e8ab1dbc6829
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
