Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/242767
Change subject: Don't double-minify JavaScript
......................................................................
Don't double-minify JavaScript
By the time we reach this code, $out consists of the concatenated
contents the requested modules, each of which is already minified
(provided debug=false). Minifying a second time does not result in
a smaller payload and it doubles the workload.
Change-Id: Id6f5142062d73b5701126724e0fe8264105f7813
---
M includes/resourceloader/ResourceLoader.php
1 file changed, 0 insertions(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/67/242767/1
diff --git a/includes/resourceloader/ResourceLoader.php
b/includes/resourceloader/ResourceLoader.php
index 4cec7ef..cba01b8 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -1067,22 +1067,6 @@
}
}
- $enableFilterCache = true;
- if ( count( $modules ) === 1 && reset( $modules ) instanceof
ResourceLoaderUserTokensModule ) {
- // If we're building the embedded user.tokens, don't
cache (T84960)
- $enableFilterCache = false;
- }
-
- if ( !$context->getDebug() ) {
- if ( $context->getOnly() === 'styles' ) {
- $out = $this->filter( 'minify-css', $out );
- } else {
- $out = $this->filter( 'minify-js', $out, array(
- 'cache' => $enableFilterCache
- ) );
- }
- }
-
return $out;
}
--
To view, visit https://gerrit.wikimedia.org/r/242767
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6f5142062d73b5701126724e0fe8264105f7813
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
