jenkins-bot has submitted this change and it was merged. Change subject: Remove lots of unused/broken use clauses ......................................................................
Remove lots of unused/broken use clauses Some of these full qualified class names don't even exist any more. Change-Id: I535319250ab277f6470c1cb80c6910154328323d --- M api/RunCrossCheck.php M includes/CrossCheck/Comparer/DataValueComparerFactory.php M includes/CrossCheck/Comparer/DispatchingDataValueComparer.php M includes/CrossCheck/Comparer/StringComparer.php M includes/CrossCheck/ValueParser/ComparativeValueParser.php M includes/CrossCheck/ValueParser/ComparativeValueParserFactory.php M includes/CrossCheck/ValueParser/MultilingualTextValueParser.php M includes/CrossCheck/ValueParser/StringValueParser.php M includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php M includes/ExternalValidationServices.php M includes/UpdateExternalData/ExternalDataImporter.php M specials/SpecialCrossCheck.php M tests/phpunit/CrossCheck/Comparer/DataValueComparerFactoryTest.php M tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php M tests/phpunit/CrossCheck/Comparer/QuantityValueComparerTest.php M tests/phpunit/CrossCheck/ValueParser/ValueParserTestBase.php M tests/phpunit/Serializer/SerializerFactoryTest.php M tests/phpunit/Specials/SpecialCrossCheckTest.php M tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php 19 files changed, 0 insertions(+), 39 deletions(-) Approvals: Jeroen De Dauw: Looks good to me, approved jenkins-bot: Verified diff --git a/api/RunCrossCheck.php b/api/RunCrossCheck.php index 049d939..51cbf4e 100755 --- a/api/RunCrossCheck.php +++ b/api/RunCrossCheck.php @@ -5,7 +5,6 @@ use ApiBase; use ApiMain; use RequestContext; -use DataValues\Serializers; use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\EntityIdParser; use Wikibase\DataModel\Services\Statement\StatementGuidValidator; diff --git a/includes/CrossCheck/Comparer/DataValueComparerFactory.php b/includes/CrossCheck/Comparer/DataValueComparerFactory.php index bc27cb7..52fb78d 100755 --- a/includes/CrossCheck/Comparer/DataValueComparerFactory.php +++ b/includes/CrossCheck/Comparer/DataValueComparerFactory.php @@ -2,7 +2,6 @@ namespace WikibaseQuality\ExternalValidation\CrossCheck\Comparer; -use Wikibase\Lib\Store\EntityLookup; use Wikibase\StringNormalizer; use Wikibase\TermIndex; diff --git a/includes/CrossCheck/Comparer/DispatchingDataValueComparer.php b/includes/CrossCheck/Comparer/DispatchingDataValueComparer.php index 1d6af0b..a1ef16b 100755 --- a/includes/CrossCheck/Comparer/DispatchingDataValueComparer.php +++ b/includes/CrossCheck/Comparer/DispatchingDataValueComparer.php @@ -5,7 +5,6 @@ use DataValues\DataValue; use InvalidArgumentException; -use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformation; /** * Class DispatchingDataValueComparer diff --git a/includes/CrossCheck/Comparer/StringComparer.php b/includes/CrossCheck/Comparer/StringComparer.php index 05ee8e9..c639117 100755 --- a/includes/CrossCheck/Comparer/StringComparer.php +++ b/includes/CrossCheck/Comparer/StringComparer.php @@ -2,7 +2,6 @@ namespace WikibaseQuality\ExternalValidation\CrossCheck\Comparer; -use InvalidArgumentException; use Wikibase\StringNormalizer; use WikibaseQuality\ExternalValidation\CrossCheck\Result\ComparisonResult; use Wikimedia\Assert\Assert; diff --git a/includes/CrossCheck/ValueParser/ComparativeValueParser.php b/includes/CrossCheck/ValueParser/ComparativeValueParser.php index ec98930..d6b32c0 100644 --- a/includes/CrossCheck/ValueParser/ComparativeValueParser.php +++ b/includes/CrossCheck/ValueParser/ComparativeValueParser.php @@ -6,7 +6,6 @@ use ValueParsers\ValueParser; use ValueParsers\ParserOptions; use Wikibase\Repo\ValueParserFactory; -use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformation; use Wikimedia\Assert\Assert; diff --git a/includes/CrossCheck/ValueParser/ComparativeValueParserFactory.php b/includes/CrossCheck/ValueParser/ComparativeValueParserFactory.php index 922775a..1d902cf 100644 --- a/includes/CrossCheck/ValueParser/ComparativeValueParserFactory.php +++ b/includes/CrossCheck/ValueParser/ComparativeValueParserFactory.php @@ -7,7 +7,6 @@ use Wikibase\Repo\ValueParserFactory; use Wikibase\Lib\DataTypeDefinitions; use Wikibase\StringNormalizer; -use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformation; use Wikimedia\Assert\Assert; /** diff --git a/includes/CrossCheck/ValueParser/MultilingualTextValueParser.php b/includes/CrossCheck/ValueParser/MultilingualTextValueParser.php index 8f6f2ba..6634842 100644 --- a/includes/CrossCheck/ValueParser/MultilingualTextValueParser.php +++ b/includes/CrossCheck/ValueParser/MultilingualTextValueParser.php @@ -2,13 +2,8 @@ namespace WikibaseQuality\ExternalValidation\CrossCheck\ValueParser; -use InvalidArgumentException; -use DataValues\DataValue; use DataValues\MultilingualTextValue; -use ValueParsers\ParserOptions; use ValueParsers\ValueParser; -use Wikibase\Repo\ValueParserFactory; -use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformation; use Wikimedia\Assert\Assert; diff --git a/includes/CrossCheck/ValueParser/StringValueParser.php b/includes/CrossCheck/ValueParser/StringValueParser.php index c838a15..8b4438d 100644 --- a/includes/CrossCheck/ValueParser/StringValueParser.php +++ b/includes/CrossCheck/ValueParser/StringValueParser.php @@ -3,12 +3,8 @@ namespace WikibaseQuality\ExternalValidation\CrossCheck\ValueParser; use DataValues\StringValue; -use InvalidArgumentException; -use DataValues\DataValue; use ValueParsers\ValueParser; use Wikibase\StringNormalizer; -use Wikibase\Test\StringNormalizerTest; -use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformation; use Wikimedia\Assert\Assert; diff --git a/includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php b/includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php index 890ed0a..f31c9dd 100755 --- a/includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php +++ b/includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php @@ -3,11 +3,9 @@ namespace WikibaseQuality\ExternalValidation\DumpMetaInformation; use DatabaseBase; -use DBError; use InvalidArgumentException; use UnexpectedValueException; use ResultWrapper; -use Wikibase\DataModel\Entity\EntityIdParser; use Wikibase\DataModel\Entity\ItemId; use Wikibase\DataModel\Entity\PropertyId; diff --git a/includes/ExternalValidationServices.php b/includes/ExternalValidationServices.php index dd9a602..c9e39c0 100755 --- a/includes/ExternalValidationServices.php +++ b/includes/ExternalValidationServices.php @@ -3,7 +3,6 @@ namespace WikibaseQuality\ExternalValidation; use DataValues\Serializers\DataValueSerializer; -use Wikibase\Repo\ValueParserFactory; use Wikibase\Repo\WikibaseRepo; use Wikibase\StringNormalizer; use WikibaseQuality\ExternalValidation\CrossCheck\Comparer\DataValueComparerFactory; diff --git a/includes/UpdateExternalData/ExternalDataImporter.php b/includes/UpdateExternalData/ExternalDataImporter.php index 231668f..fa0f6fe 100755 --- a/includes/UpdateExternalData/ExternalDataImporter.php +++ b/includes/UpdateExternalData/ExternalDataImporter.php @@ -2,14 +2,10 @@ namespace WikibaseQuality\ExternalValidation\UpdateExternalData; -use DateTime; -use DateTimeZone; -use PharData; use Wikibase\DataModel\Entity\ItemId; use Wikibase\DataModel\Entity\PropertyId; use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformation; use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformationStore; -use WikibaseQuality\ExternalValidation\DumpMetaInformation\SqlDumpMetaInformationRepo; use WikibaseQuality\ExternalValidation\ExternalDataRepo; diff --git a/specials/SpecialCrossCheck.php b/specials/SpecialCrossCheck.php index cb13816..ef8fb82 100755 --- a/specials/SpecialCrossCheck.php +++ b/specials/SpecialCrossCheck.php @@ -7,7 +7,6 @@ use UnexpectedValueException; use Html; use HTMLForm; -use JobQueueGroup; use Linker; use SpecialPage; use Traversable; diff --git a/tests/phpunit/CrossCheck/Comparer/DataValueComparerFactoryTest.php b/tests/phpunit/CrossCheck/Comparer/DataValueComparerFactoryTest.php index 15d08c9..73fdfb5 100755 --- a/tests/phpunit/CrossCheck/Comparer/DataValueComparerFactoryTest.php +++ b/tests/phpunit/CrossCheck/Comparer/DataValueComparerFactoryTest.php @@ -15,8 +15,6 @@ use Wikibase\DataModel\Entity\ItemId; use WikibaseQuality\ExternalValidation\CrossCheck\Comparer\DataValueComparer; use WikibaseQuality\ExternalValidation\CrossCheck\Comparer\DataValueComparerFactory; -use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformation; -use WikibaseQuality\Tests\Helper\JsonFileEntityLookup; /** * @covers WikibaseQuality\ExternalValidation\CrossCheck\Comparer\DataValueComparerFactory diff --git a/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php b/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php index 0be319d..6e4c755 100755 --- a/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php +++ b/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php @@ -5,8 +5,6 @@ use DataValues\MonolingualTextValue; use DataValues\QuantityValue; use DataValues\StringValue; -use Wikibase\DataModel\Entity\EntityIdValue; -use Wikibase\DataModel\Entity\ItemId; use WikibaseQuality\ExternalValidation\CrossCheck\Comparer\MonolingualTextValueComparer; use WikibaseQuality\ExternalValidation\CrossCheck\Result\ComparisonResult; diff --git a/tests/phpunit/CrossCheck/Comparer/QuantityValueComparerTest.php b/tests/phpunit/CrossCheck/Comparer/QuantityValueComparerTest.php index 878170d..df3ee41 100755 --- a/tests/phpunit/CrossCheck/Comparer/QuantityValueComparerTest.php +++ b/tests/phpunit/CrossCheck/Comparer/QuantityValueComparerTest.php @@ -6,8 +6,6 @@ use DataValues\MonolingualTextValue; use DataValues\QuantityValue; use DataValues\StringValue; -use Wikibase\DataModel\Entity\EntityIdValue; -use Wikibase\DataModel\Entity\ItemId; use WikibaseQuality\ExternalValidation\CrossCheck\Comparer\QuantityValueComparer; use WikibaseQuality\ExternalValidation\CrossCheck\Result\ComparisonResult; diff --git a/tests/phpunit/CrossCheck/ValueParser/ValueParserTestBase.php b/tests/phpunit/CrossCheck/ValueParser/ValueParserTestBase.php index e671623..c9180dc 100755 --- a/tests/phpunit/CrossCheck/ValueParser/ValueParserTestBase.php +++ b/tests/phpunit/CrossCheck/ValueParser/ValueParserTestBase.php @@ -2,11 +2,7 @@ namespace WikibaseQuality\ExternalValidation\Tests\CrossCheck\ValueParser; -use DataValues\DataValue; use ValueParsers\ValueParser; -use WikibaseQuality\ExternalValidation\CrossCheck\ComparativeValueParser\ComparativeValueParser; -use WikibaseQuality\ExternalValidation\CrossCheck\Comparer\DataValueComparer; -use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformation; /** diff --git a/tests/phpunit/Serializer/SerializerFactoryTest.php b/tests/phpunit/Serializer/SerializerFactoryTest.php index 40c9420..c7845b8 100755 --- a/tests/phpunit/Serializer/SerializerFactoryTest.php +++ b/tests/phpunit/Serializer/SerializerFactoryTest.php @@ -4,7 +4,6 @@ use DataValues\Serializers\DataValueSerializer; use DataValues\StringValue; -use MwTimestamp; use Serializers\Serializer; use Wikibase\DataModel\Entity\ItemId; use Wikibase\DataModel\Entity\PropertyId; @@ -12,7 +11,6 @@ use Wikibase\DataModel\Serializers\ReferenceSerializer; use Wikibase\DataModel\Serializers\SnakListSerializer; use Wikibase\DataModel\Serializers\SnakSerializer; -use Wikibase\DataModel\Serializers\SnaksSerializer; use WikibaseQuality\ExternalValidation\CrossCheck\Result\ComparisonResult; use WikibaseQuality\ExternalValidation\CrossCheck\Result\CrossCheckResult; use WikibaseQuality\ExternalValidation\CrossCheck\Result\CrossCheckResultList; diff --git a/tests/phpunit/Specials/SpecialCrossCheckTest.php b/tests/phpunit/Specials/SpecialCrossCheckTest.php index 1c9fb0e..01c4b20 100755 --- a/tests/phpunit/Specials/SpecialCrossCheckTest.php +++ b/tests/phpunit/Specials/SpecialCrossCheckTest.php @@ -18,7 +18,6 @@ use Wikibase\DataModel\Entity\Property; use Wikibase\DataModel\Snak\PropertyValueSnak; use Wikibase\DataModel\Statement\Statement; -use Wikibase\Lib\ClaimGuidGenerator; use Wikibase\Repo\WikibaseRepo; use Wikibase\DataModel\Entity\EntityId; diff --git a/tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php b/tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php index 473b961..7b82c03 100755 --- a/tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php +++ b/tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php @@ -2,9 +2,6 @@ namespace WikibaseQuality\ExternalValidation\Tests\UpdateExternalData; -use Wikibase\DataModel\Entity\BasicEntityIdParser; -use Wikibase\DataModel\Entity\ItemId; -use Wikibase\DataModel\Entity\PropertyId; use WikibaseQuality\ExternalValidation\DumpMetaInformation\SqlDumpMetaInformationRepo; use WikibaseQuality\ExternalValidation\ExternalDataRepo; use WikibaseQuality\ExternalValidation\Maintenance\UpdateExternalData; -- To view, visit https://gerrit.wikimedia.org/r/242577 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I535319250ab277f6470c1cb80c6910154328323d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]> Gerrit-Reviewer: Hoo man <[email protected]> Gerrit-Reviewer: JanZerebecki <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
