Brian Wolff has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/242790

Change subject: Make hook take array by reference
......................................................................

Make hook take array by reference

Locally, array values in hooks don't seem to need the & to be
given by reference, but this doesn't seem to be working on cluster,
and certainly, it should not work.

The added special pages aren't being listed in docs for
list=querypages, and they haven't seem to be updated since
2015-09-07T18:17:41, despite the fact they should be every 3
days.

Change-Id: I4d90c8f862bc8dcce1d87f2383412348c88a2898
---
M GlobalUsageHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GlobalUsage 
refs/changes/90/242790/1

diff --git a/GlobalUsageHooks.php b/GlobalUsageHooks.php
index d965442..65a76c6 100644
--- a/GlobalUsageHooks.php
+++ b/GlobalUsageHooks.php
@@ -235,7 +235,7 @@
                return true;
        }
 
-       public static function onwgQueryPages( $queryPages ) {
+       public static function onwgQueryPages( &$queryPages ) {
                $queryPages[] = array( 'MostGloballyLinkedFilesPage', 
'MostGloballyLinkedFiles' );
                $queryPages[] = array( 'SpecialGloballyWantedFiles', 
'GloballyWantedFiles' );
                return true;

-- 
To view, visit https://gerrit.wikimedia.org/r/242790
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d90c8f862bc8dcce1d87f2383412348c88a2898
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalUsage
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to