Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/242798

Change subject: Remove dead function argument
......................................................................

Remove dead function argument

Change-Id: Iba01944a0a28079aabd6cdf7f6e24587df68cf82
---
M includes/CrossCheck/Comparer/TimeValueComparer.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityExternalValidation
 refs/changes/98/242798/1

diff --git a/includes/CrossCheck/Comparer/TimeValueComparer.php 
b/includes/CrossCheck/Comparer/TimeValueComparer.php
index 5825920..4f646c2 100644
--- a/includes/CrossCheck/Comparer/TimeValueComparer.php
+++ b/includes/CrossCheck/Comparer/TimeValueComparer.php
@@ -38,7 +38,7 @@
                try {
                        $localTimestamp = new 
MWTimestamp(substr($value->getTime(), 1));
                        $externalTimestamp = new 
MWTimestamp(substr($comparativeValue->getTime(), 1));
-                       $diff = $localTimestamp->diff( $externalTimestamp, true 
);
+                       $diff = $localTimestamp->diff( $externalTimestamp );
 
                        if ( $value->getPrecision() === 
$comparativeValue->getPrecision()
                                        && $this->resultOfDiffWithPrecision( 
$diff, $value->getPrecision() ) ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/242798
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba01944a0a28079aabd6cdf7f6e24587df68cf82
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to