jenkins-bot has submitted this change and it was merged.
Change subject: NewsletterTablePager: Link to Special:Newsletter/id instead of
main page on 'newsletter name' field
......................................................................
NewsletterTablePager: Link to Special:Newsletter/id instead of main page on
'newsletter name' field
Change-Id: I7ee7eaf9b446cef96571a2d7740a6cb14be3cf6d
---
M includes/specials/pagers/NewsletterTablePager.php
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
01tonythomas: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/pagers/NewsletterTablePager.php
b/includes/specials/pagers/NewsletterTablePager.php
index 4900fa9..24673dd 100644
--- a/includes/specials/pagers/NewsletterTablePager.php
+++ b/includes/specials/pagers/NewsletterTablePager.php
@@ -39,7 +39,6 @@
'tables' => array( 'nl_newsletters' ),
'fields' => array(
'nl_name',
- 'nl_main_page_id',
'nl_desc',
'nl_id',
'nl_frequency',
@@ -55,9 +54,9 @@
public function formatValue( $field, $value ) {
switch ( $field ) {
case 'nl_name':
- $title = Title::newFromID(
$this->mCurrentRow->nl_main_page_id );
+ $title = SpecialPage::getTitleFor(
'Newsletter', $this->mCurrentRow->nl_id );
if ( $title ) {
- return Linker::link( $title,
htmlspecialchars( $value ) );
+ return Linker::linkKnown( $title,
htmlspecialchars( $value ) );
} else {
return htmlspecialchars( $value );
}
--
To view, visit https://gerrit.wikimedia.org/r/242854
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ee7eaf9b446cef96571a2d7740a6cb14be3cf6d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Glaisher <[email protected]>
Gerrit-Reviewer: 01tonythomas <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
