jenkins-bot has submitted this change and it was merged.
Change subject: Move references disabling to statementview
......................................................................
Move references disabling to statementview
Change-Id: I67cca39ff809dc1e300de7a17fcd4cc29fa20a2a
---
M view/resources/jquery/wikibase/jquery.wikibase.itemview.js
M view/resources/jquery/wikibase/jquery.wikibase.propertyview.js
M view/resources/jquery/wikibase/jquery.wikibase.statementview.js
3 files changed, 1 insertion(+), 15 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.itemview.js
b/view/resources/jquery/wikibase/jquery.wikibase.itemview.js
index ed5d4fb..1846b45 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.itemview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.itemview.js
@@ -130,14 +130,6 @@
PARENT.prototype._setState.call( this, state );
this.$statements.data( 'statementgrouplistview' )[state]();
- // TODO: Resolve integration of referenceviews
- this.$statements.find( '.wikibase-statementview-references'
).each( function() {
- var $listview = $( this ).children(
':wikibase-listview' );
- if( $listview.length ) {
- $listview.data( 'listview' )[state]();
- }
- } );
-
this.$siteLinks.data( 'sitelinkgrouplistview' )[state]();
}
} );
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.propertyview.js
b/view/resources/jquery/wikibase/jquery.wikibase.propertyview.js
index d123bf5..dc54cc4 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.propertyview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.propertyview.js
@@ -138,13 +138,6 @@
PARENT.prototype._setState.call( this, state );
this.$statements.data( 'statementgrouplistview' )[state]();
- // TODO: Resolve integration of referenceviews
- this.$statements.find( '.wikibase-statementview-references'
).each( function() {
- var $listview = $( this ).children(
':wikibase-listview' );
- if( $listview.length ) {
- $listview.data( 'listview' )[state]();
- }
- } );
}
} );
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
index 312227a..f33f4f1 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
@@ -835,6 +835,7 @@
this._qualifiers.option( key, value );
}
this._rankSelector.option( key, value );
+ this._referencesListview.option( key, value );
}
return response;
--
To view, visit https://gerrit.wikimedia.org/r/242834
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67cca39ff809dc1e300de7a17fcd4cc29fa20a2a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
