jenkins-bot has submitted this change and it was merged.
Change subject: objectcache: Add some newlines to WANObjectCache docs
......................................................................
objectcache: Add some newlines to WANObjectCache docs
* Doxygen needs this or the paragraph ends up in the
last bullet point
* Also removed some redundant comments
Change-Id: Ie4bf2b67fff27ecad5f24f55688161fe484c300d
---
M includes/libs/objectcache/WANObjectCache.php
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/libs/objectcache/WANObjectCache.php
b/includes/libs/objectcache/WANObjectCache.php
index 7e8db0c..435d69b 100644
--- a/includes/libs/objectcache/WANObjectCache.php
+++ b/includes/libs/objectcache/WANObjectCache.php
@@ -165,6 +165,7 @@
* isolation can largely be maintained by doing the following:
* - a) Calling delete() on entity change *and* creation, before DB
commit
* - b) Keeping transaction duration shorter than delete() hold-off
TTL
+ *
* However, pre-snapshot values might still be seen if an update was
made
* in a remote datacenter but the purge from delete() didn't relay yet.
*
@@ -457,6 +458,7 @@
* - b) Thus, dependent keys will be known to be invalid, but not
* for how long (they are treated as "just" purged), which
* effects any lockTSE logic in getWithSetCallback()
+ *
* The advantage is that this does not place high TTL keys on every
cache
* server, making it better for code that will cache many different keys
* and either does not use lockTSE or uses a low enough TTL anyway.
@@ -506,9 +508,6 @@
* the 'lockTSE' option in $opts. If cache purges are needed, also:
* - a) Pass $key into $checkKeys
* - b) Use touchCheckKey( $key ) instead of delete( $key )
- * Following this pattern lets the old cache be used until a
- * single thread updates it as needed. Also consider tweaking
- * the 'lowTTL' parameter.
*
* Example usage (typical key):
* @code
--
To view, visit https://gerrit.wikimedia.org/r/242826
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4bf2b67fff27ecad5f24f55688161fe484c300d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
