Awight has uploaded a new change for review.
https://gerrit.wikimedia.org/r/243069
Change subject: Help text for the impression diet feature
......................................................................
Help text for the impression diet feature
Change-Id: I00734ebe8a365b82a9029d815bcf7a6a07f5ca53
---
M CentralNotice.php
M i18n/en.json
M i18n/qqq.json
3 files changed, 10 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/69/243069/1
diff --git a/CentralNotice.php b/CentralNotice.php
index 5439675..dc8ccdd 100644
--- a/CentralNotice.php
+++ b/CentralNotice.php
@@ -293,6 +293,7 @@
'impressionDiet' => array(
'module' => 'ext.centralNotice.impressionDiet',
'nameMsg' => 'centralnotice-impression-diet',
+ 'helpMsg' => 'centralnotice-impression-diet-help',
'parameters' => array(
'cookieName' => array(
'type' => 'string',
diff --git a/i18n/en.json b/i18n/en.json
index a8eeb8f..16970e2 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -273,6 +273,7 @@
"centralnotice-custom-record-impression-sample-rate":
"Special:RecordImpression sample rate (should be between 0 and 1 inclusive)",
"centralnotice-banners-not-guaranteed-to-display": "Banners might not
display, as determined by in-banner JavaScript",
"centralnotice-impression-diet": "Impression diet",
+ "centralnotice-impression-diet-help": "Limit the number of banners seen
by any one individual.",
"centralnotice-impression-diet-cookie-name": "Hide cookie name",
"centralnotice-impression-diet-cookie-name-help": "To share an
impression counting threshold across campaigns, specify the same cookie name
for each campaign. If the cookie name is changed during a campaign, all counts
to date will be lost.",
"centralnotice-impression-diet-maximum-seen": "Maximum impressions any
individual will see",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index af1a162..f265cc6 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -296,11 +296,13 @@
"centralnotice-set-record-impression-sample-rate": "Label for the
control to activate setting the sample rate for Special:RecordImpression, for
the legacy support campaign mixin",
"centralnotice-custom-record-impression-sample-rate": "Label for the
control to determine the sample rate for Special:RecordImpression, for the
legacy support campaign mixin",
"centralnotice-banners-not-guaranteed-to-display": "Label for the
control to indicate that banners might not display, for the legacy support
campaign mixin",
- "centralnotice-impression-diet-cookie-name": "Label for the form
control to set diet cookie name.",
- "centralnotice-impression-diet-cookie-name-help": "Help text for form
control.",
- "centralnotice-impression-diet-maximum-seen": "Label for the form
control to set maximum seen count.",
- "centralnotice-impression-diet-maximum-seen-help": "Help text for form
control.",
+ "centralnotice-impression-diet": "Label for the banner impression diet
mixin",
+ "centralnotice-impression-diet-help": "Help text for the banner
impression diet mixin",
+ "centralnotice-impression-diet-cookie-name": "Label for the form
control to set diet cookie name",
+ "centralnotice-impression-diet-cookie-name-help": "Help text for form
control",
+ "centralnotice-impression-diet-maximum-seen": "Label for the form
control to set maximum seen count",
+ "centralnotice-impression-diet-maximum-seen-help": "Help text for form
control",
"centralnotice-impression-diet-restart-cycle-delay": "Label for the
form control to set cycle restart delay",
- "centralnotice-impression-diet-skip-initial": "Label for the form
control to skip initial impressions.",
- "centralnotice-impression-diet-skip-initial-help": "Help text for form
control."
+ "centralnotice-impression-diet-skip-initial": "Label for the form
control to skip initial impressions",
+ "centralnotice-impression-diet-skip-initial-help": "Help text for form
control"
}
--
To view, visit https://gerrit.wikimedia.org/r/243069
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00734ebe8a365b82a9029d815bcf7a6a07f5ca53
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
