Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/243098
Change subject: Remove dead reference to
.ve-init-mw-viewPageTarget-saveDialog-slide-review
......................................................................
Remove dead reference to .ve-init-mw-viewPageTarget-saveDialog-slide-review
Bug: T111842
Change-Id: I49bd1459d0330a1e824d10f076ab8cb440a82372
---
M modules/ext.guidedTour.lib/ext.guidedTour.lib.main.js
1 file changed, 2 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GuidedTour
refs/changes/98/243098/1
diff --git a/modules/ext.guidedTour.lib/ext.guidedTour.lib.main.js
b/modules/ext.guidedTour.lib/ext.guidedTour.lib.main.js
index 5ef5080..a64e0b2 100644
--- a/modules/ext.guidedTour.lib/ext.guidedTour.lib.main.js
+++ b/modules/ext.guidedTour.lib/ext.guidedTour.lib.main.js
@@ -710,6 +710,7 @@
return typeof ve !== 'undefined' && ve.instances &&
ve.instances.length > 0;
},
+ // TODO: Doesn't currently detect reviewing with VE
/**
* Checks whether the user is previewing or reviewing changes
* (after clicking "Show changes")
@@ -717,7 +718,7 @@
* @return {boolean} true if and only if they are reviewing
*/
isReviewing: function () {
- return gt.isReviewingWithWikitext() ||
gt.isReviewingWithVisualEditor();
+ return gt.isReviewingWithWikitext();
},
/**
@@ -728,15 +729,6 @@
*/
isReviewingWithWikitext: function () {
return mw.config.get( 'wgAction' ) === 'submit';
- },
-
- /**
- * Checks whether the user is in the dialog for reviewing
VisualEditor changes
- *
- * @return {boolean} true if and only if they are reviewing
VisualEditor changes
- */
- isReviewingWithVisualEditor: function () {
- return $(
'.ve-init-mw-viewPageTarget-saveDialog-slide-review' ).is( ':visible' );
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/243098
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49bd1459d0330a1e824d10f076ab8cb440a82372
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GuidedTour
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
