jenkins-bot has submitted this change and it was merged.
Change subject: build: Enable jscs jsDoc rule 'checkParamNames' and make pass
......................................................................
build: Enable jscs jsDoc rule 'checkParamNames' and make pass
* order @param annotations correctly in wikibase.view.ViewFactory
* add missing @param names to wikibase.entityChangers constructors
DescriptionsChanger, LabelsChanger and SiteLinksChanger
* moved an @event annotation after a constructor
in jQuery.wikibase.snakview.variations.Variation
Bug: T110811
Change-Id: I9ce24f32bf36672f6876fc46ef5cfdbf5910357f
---
M .jscsrc
M view/resources/jquery/wikibase/snakview/snakview.variations.Variation.js
M view/resources/wikibase/entityChangers/DescriptionsChanger.js
M view/resources/wikibase/entityChangers/LabelsChanger.js
M view/resources/wikibase/entityChangers/SiteLinksChanger.js
M view/resources/wikibase/view/ViewFactory.js
6 files changed, 17 insertions(+), 17 deletions(-)
Approvals:
Hoo man: Looks good to me, but someone else must approve
Thiemo Mättig (WMDE): Looks good to me, approved
Jeroen De Dauw: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/.jscsrc b/.jscsrc
index bae0d05..0ab8d67 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -13,7 +13,7 @@
"jsDoc": {
// what we don't yet follow is commented out
//"checkAnnotations": "jsduck5",
- //"checkParamNames": true,
+ "checkParamNames": true,
"requireParamTypes": true,
"checkRedundantParams": true,
//"checkReturnTypes": true,
diff --git
a/view/resources/jquery/wikibase/snakview/snakview.variations.Variation.js
b/view/resources/jquery/wikibase/snakview/snakview.variations.Variation.js
index 32c445a..5433f19 100644
--- a/view/resources/jquery/wikibase/snakview/snakview.variations.Variation.js
+++ b/view/resources/jquery/wikibase/snakview/snakview.variations.Variation.js
@@ -35,11 +35,6 @@
*
* @throws {Error} if a required parameter is not specified properly.
*/
- /**
- * @event afterdraw
- * Triggered on the `Variation` object after drawing the `Variation`.
- * @param {jQuery.Event} event
- */
var SELF = $.wikibase.snakview.variations.Variation = function
WbSnakviewVariationsVariation(
viewState,
$viewPort,
@@ -64,6 +59,11 @@
this._init();
};
+ /**
+ * @event afterdraw
+ * Triggered on the `Variation` object after drawing the `Variation`.
+ * @param {jQuery.Event} event
+ */
$.extend( SELF.prototype, {
/**
* A unique class for this `Variation`, applied to the
`Variation` DOM's `class` attribute.
diff --git a/view/resources/wikibase/entityChangers/DescriptionsChanger.js
b/view/resources/wikibase/entityChangers/DescriptionsChanger.js
index c20a80d..3c73bd9 100644
--- a/view/resources/wikibase/entityChangers/DescriptionsChanger.js
+++ b/view/resources/wikibase/entityChangers/DescriptionsChanger.js
@@ -7,9 +7,9 @@
var MODULE = wb.entityChangers;
/**
- * @param {wikibase.api.RepoApi}
- * @param {wikibase.RevisionStore}
- * @param {wikibase.datamodel.Entity}
+ * @param {wikibase.api.RepoApi} api
+ * @param {wikibase.RevisionStore} revisionStore
+ * @param {wikibase.datamodel.Entity} entity
*/
var SELF = MODULE.DescriptionsChanger = function
WbEntityChangersDescriptionsChanger( api, revisionStore, entity ) {
this._api = api;
diff --git a/view/resources/wikibase/entityChangers/LabelsChanger.js
b/view/resources/wikibase/entityChangers/LabelsChanger.js
index 66dff8c..f1d6b96 100644
--- a/view/resources/wikibase/entityChangers/LabelsChanger.js
+++ b/view/resources/wikibase/entityChangers/LabelsChanger.js
@@ -7,9 +7,9 @@
var MODULE = wb.entityChangers;
/**
- * @param {wikibase.api.RepoApi}
- * @param {wikibase.RevisionStore}
- * @param {wikibase.datamodel.Entity}
+ * @param {wikibase.api.RepoApi} api
+ * @param {wikibase.RevisionStore} revisionStore
+ * @param {wikibase.datamodel.Entity} entity
*/
var SELF = MODULE.LabelsChanger = function
WbEntityChangersLabelsChanger( api, revisionStore, entity ) {
this._api = api;
diff --git a/view/resources/wikibase/entityChangers/SiteLinksChanger.js
b/view/resources/wikibase/entityChangers/SiteLinksChanger.js
index 4b06c7f..12987e7 100644
--- a/view/resources/wikibase/entityChangers/SiteLinksChanger.js
+++ b/view/resources/wikibase/entityChangers/SiteLinksChanger.js
@@ -7,9 +7,9 @@
var MODULE = wb.entityChangers;
/**
- * @param {wikibase.api.RepoApi}
- * @param {wikibase.RevisionStore}
- * @param {wikibase.datamodel.Entity}
+ * @param {wikibase.api.RepoApi} api
+ * @param {wikibase.RevisionStore} revisionStore
+ * @param {wikibase.datamodel.Entity} entity
*/
var SELF = MODULE.SiteLinksChanger = function
WbEntityChangersSiteLinksChanger( api, revisionStore, entity ) {
this._api = api;
diff --git a/view/resources/wikibase/view/ViewFactory.js
b/view/resources/wikibase/view/ViewFactory.js
index a8bbbb1..e4903fc 100644
--- a/view/resources/wikibase/view/ViewFactory.js
+++ b/view/resources/wikibase/view/ViewFactory.js
@@ -19,12 +19,12 @@
* @param {dataTypes.DataTypeStore} dataTypeStore
* Required by the `snakview` for retrieving and evaluating a
proper `dataTypes.DataType`
* object when interacting on a "value" `Variation`.
+ * @param {wikibase.entityChangers.EntityChangersFactory}
entityChangersFactory
+ * Required to store changed data.
* @param {wikibase.entityIdFormatter.EntityIdHtmlFormatter}
entityIdHtmlFormatter
* Required by several views for rendering links to entities.
* @param {wikibase.entityIdFormatter.EntityIdPlainFormatter}
entityIdPlainFormatter
* Required by several views for rendering plain text references
to entities.
- * @param {wikibase.entityChangers.EntityChangersFactory}
entityChangersFactory
- * Required to store changed data.
* @param {wikibase.store.EntityStore} entityStore
* Required for dynamically gathering `Entity`/`Property`
information.
* @param {jQuery.valueview.ExpertStore} expertStore
--
To view, visit https://gerrit.wikimedia.org/r/243090
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ce24f32bf36672f6876fc46ef5cfdbf5910357f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
