Jonas Kress (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/243135
Change subject: Fix merging of entity usage aspects
......................................................................
Fix merging of entity usage aspects
Fix merging of entity usage aspects by using array_merge instead of '+'
in AffectedPagesFinder.
Found while investigating bug T112649.
Bug: T112649
Change-Id: I84f3b4dfa76731e4648a19913d0ad14e32ab02fb
---
M client/includes/Changes/AffectedPagesFinder.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/35/243135/1
diff --git a/client/includes/Changes/AffectedPagesFinder.php
b/client/includes/Changes/AffectedPagesFinder.php
index b8d1376..69a5339 100644
--- a/client/includes/Changes/AffectedPagesFinder.php
+++ b/client/includes/Changes/AffectedPagesFinder.php
@@ -188,7 +188,7 @@
// @todo: more than one entity at once!
array( $entityId ),
// Look up pages that are marked as either using one of
the changed or all aspects
- $changedAspects + array( EntityUsage::ALL_USAGE )
+ array_merge( $changedAspects, array(
EntityUsage::ALL_USAGE ) )
);
// @todo: use iterators throughout!
--
To view, visit https://gerrit.wikimedia.org/r/243135
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84f3b4dfa76731e4648a19913d0ad14e32ab02fb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
