Alexandros Kosiaris has submitted this change and it was merged.
Change subject: actually use is_critical in monitor_replication
......................................................................
actually use is_critical in monitor_replication
All service check were unconditionally marked as critical. Switch to
using the parameter is_critical passed to the definition.
Add comments to really revisit that soon, and set up a better paging
alerting scheme
Change-Id: I1b2c1d6aa9079e7b89b592079f0c159b15dfbc20
---
M manifests/monitor_disk.pp
M manifests/monitor_process.pp
M manifests/monitor_replication.pp
3 files changed, 9 insertions(+), 5 deletions(-)
Approvals:
Alexandros Kosiaris: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/manifests/monitor_disk.pp b/manifests/monitor_disk.pp
index 09f6067..043606d 100644
--- a/manifests/monitor_disk.pp
+++ b/manifests/monitor_disk.pp
@@ -1,3 +1,5 @@
+# TODO: Revisit the is_critical part. We probably want pages for DB problems
for
+# at least a group of people
class mariadb::monitor_disk(
$is_critical = true,
$contact_group = 'dba',
diff --git a/manifests/monitor_process.pp b/manifests/monitor_process.pp
index 295a278..8e96f63 100644
--- a/manifests/monitor_process.pp
+++ b/manifests/monitor_process.pp
@@ -1,4 +1,5 @@
-
+# TODO: Revisit the is_critical part. We probably want pages for DB problems
for
+# at least a group of people
class mariadb::monitor_process(
$is_critical = true,
$contact_group = 'dba',
diff --git a/manifests/monitor_replication.pp b/manifests/monitor_replication.pp
index 99130ec..8d26cce 100644
--- a/manifests/monitor_replication.pp
+++ b/manifests/monitor_replication.pp
@@ -1,5 +1,6 @@
# MariaDB 10 multi-source replication
-
+# TODO: Revisit the is_critical part. We probably want pages for DB problems
for
+# at least a group of people
define mariadb::monitor_replication(
$is_critical = true,
$contact_group = 'dba',
@@ -30,21 +31,21 @@
nrpe::monitor_service { "mariadb_slave_io_state_${name}":
description => "MariaDB Slave IO: ${name}",
nrpe_command => "${check_mariadb} --check=slave_io_state",
- critical => true,
+ critical => $is_critical,
contact_group => $contact_group,
}
nrpe::monitor_service { "mariadb_slave_sql_state_${name}":
description => "MariaDB Slave SQL: ${name}",
nrpe_command => "${check_mariadb} --check=slave_sql_state",
- critical => true,
+ critical => $is_critical,
contact_group => $contact_group,
}
nrpe::monitor_service { "mariadb_slave_sql_lag_${name}":
description => "MariaDB Slave Lag: ${name}",
nrpe_command => "${check_mariadb} --check=slave_sql_lag
--sql-lag-warn=${lag_warn} --sql-lag-crit=${lag_crit}",
- critical => true,
+ critical => $is_critical,
contact_group => $contact_group,
}
}
--
To view, visit https://gerrit.wikimedia.org/r/242452
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b2c1d6aa9079e7b89b592079f0c159b15dfbc20
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet/mariadb
Gerrit-Branch: master
Gerrit-Owner: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Jcrespo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
