Yaron Koren has submitted this change and it was merged.
Change subject: Do not use extension.json for MW 1.25.1 or 1.25.2, due to bug
in those
......................................................................
Do not use extension.json for MW 1.25.1 or 1.25.2, due to bug in those
Change-Id: Icfba665a8999f2cd2bc04dc11a33b86db0a713d2
---
M Cargo.php
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Yaron Koren: Checked; Looks good to me, approved
diff --git a/Cargo.php b/Cargo.php
index 6f7ff2b..be49190 100644
--- a/Cargo.php
+++ b/Cargo.php
@@ -11,7 +11,12 @@
// extensions to determine whether Cargo is installed.
define( 'CARGO_VERSION', '0.10-alpha' );
-if ( function_exists( 'wfLoadExtension' ) ) {
+// There's a bug in extension loading in versions 1.25.1 and 1.25.2 that
+// makes it unusable for Cargo - don't load extensions unless we're at
+// version 1.25.3 or higher.
+// (See https://phabricator.wikimedia.org/T109243)
+//if ( function_exists( 'wfLoadExtension' ) ) {
+if ( version_compare( $wgVersion, '1.25.3', '>=' ) ) {
wfLoadExtension( 'Cargo' );
// Keep i18n globals so mergeMessageFileList.php doesn't break
$wgMessagesDirs['Cargo'] = __DIR__ . '/i18n';
--
To view, visit https://gerrit.wikimedia.org/r/243175
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfba665a8999f2cd2bc04dc11a33b86db0a713d2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
