Andrew Bogott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/243178
Change subject: labstore: rearrange args to cleanup_snapshots
......................................................................
labstore: rearrange args to cleanup_snapshots
Previously we had an optional arg before a required one, which
doesn't make a ton of sense.
Only called in one place which is unaffected by this change.
Change-Id: I6c39427c5d868ba47bb1563915d10649bda7ed68
---
M modules/labstore/manifests/fileserver/cleanup_snapshots.pp
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/78/243178/1
diff --git a/modules/labstore/manifests/fileserver/cleanup_snapshots.pp
b/modules/labstore/manifests/fileserver/cleanup_snapshots.pp
index 175cfbe..65aea67 100644
--- a/modules/labstore/manifests/fileserver/cleanup_snapshots.pp
+++ b/modules/labstore/manifests/fileserver/cleanup_snapshots.pp
@@ -3,12 +3,12 @@
# volumes created by replication
#
# Parameters:
-# volume_group = volume group to clean
# keep_free = free space to keep (in terabytes)
+# volume_group = volume group to clean
#
define labstore::fileserver::cleanup_snapshots(
- $volume_group = $title,
$keep_free,
+ $volume_group = $title,
) {
base::service_unit { "cleanup-snapshots-${volume_group}":
template_name => 'cleanup-snapshots',
--
To view, visit https://gerrit.wikimedia.org/r/243178
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c39427c5d868ba47bb1563915d10649bda7ed68
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott <abog...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
