jenkins-bot has submitted this change and it was merged.

Change subject: RESTBase: use the domain name as defined by role::mediawiki
......................................................................


RESTBase: use the domain name as defined by role::mediawiki

Instead of 'hard-coding' RESTBase's domain to 'localhost', use the
hostname as provided by role::mediawiki(::hostname), since this is the
same domain name as used by Parsoid as well.

Bug: T111223
Change-Id: I0b50af3854c7c55d6553563e81ddc5917d9d7757
---
M puppet/hieradata/common.yaml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  BryanDavis: Looks good to me, approved
  Cscott: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/puppet/hieradata/common.yaml b/puppet/hieradata/common.yaml
index a1bf0fa..d5f9652 100644
--- a/puppet/hieradata/common.yaml
+++ b/puppet/hieradata/common.yaml
@@ -247,7 +247,7 @@
 redis::max_memory: 256M
 
 restbase::port: 7231
-restbase::domain: localhost
+restbase::domain: "%{hiera('role::mediawiki::hostname')}"
 restbase::dbdir: /var/lib/restbase
 
 role::commons::upload_dir: "%{hiera('mwv::files_dir')}/commonsimages"

-- 
To view, visit https://gerrit.wikimedia.org/r/243147
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b50af3854c7c55d6553563e81ddc5917d9d7757
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Mobrovac <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: Dduvall <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to