Thiemo Mättig (WMDE) has submitted this change and it was merged.

Change subject: Drop dead variable from UsageTrackingIntegrationTest
......................................................................


Drop dead variable from UsageTrackingIntegrationTest

Change-Id: I525cf04ca924134ff35b40f67a21e0994a89ffde
---
M client/tests/phpunit/includes/Usage/UsageTrackingIntegrationTest.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Hoo man: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/client/tests/phpunit/includes/Usage/UsageTrackingIntegrationTest.php 
b/client/tests/phpunit/includes/Usage/UsageTrackingIntegrationTest.php
index 02914f4..90fca14 100644
--- a/client/tests/phpunit/includes/Usage/UsageTrackingIntegrationTest.php
+++ b/client/tests/phpunit/includes/Usage/UsageTrackingIntegrationTest.php
@@ -141,9 +141,9 @@
        private function waitForNextTimestamp() {
                $timestamp = wfTimestampNow();
 
-               while ( ( $now = wfTimestampNow() ) === $timestamp ) {
+               do {
                        usleep( 100 * 1000 );
-               }
+               } while ( wfTimestampNow() === $timestamp );
        }
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/242542
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I525cf04ca924134ff35b40f67a21e0994a89ffde
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to