jenkins-bot has submitted this change and it was merged.
Change subject: Remove redundant argument
......................................................................
Remove redundant argument
Change-Id: Ia74a7b828945e38578885e64d8c2b676695e5eae
---
M includes/CrossCheck/Comparer/TimeValueComparer.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/CrossCheck/Comparer/TimeValueComparer.php
b/includes/CrossCheck/Comparer/TimeValueComparer.php
index 2ea130c..04117e8 100644
--- a/includes/CrossCheck/Comparer/TimeValueComparer.php
+++ b/includes/CrossCheck/Comparer/TimeValueComparer.php
@@ -46,7 +46,7 @@
// FIXME: MWTimestamp does not support years with more
than 4 digits!
$localTimestamp = new MWTimestamp( substr(
$value->getTime(), 1 ) );
$externalTimestamp = new MWTimestamp( substr(
$comparativeValue->getTime(), 1 ) );
- $diff = $localTimestamp->diff( $externalTimestamp, true
);
+ $diff = $localTimestamp->diff( $externalTimestamp );
if ( $value->getPrecision() ===
$comparativeValue->getPrecision()
&& $this->resultOfDiffWithPrecision( $diff,
$value->getPrecision() )
--
To view, visit https://gerrit.wikimedia.org/r/243490
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia74a7b828945e38578885e64d8c2b676695e5eae
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
