jenkins-bot has submitted this change and it was merged.
Change subject: Remove not needed and
......................................................................
Remove not needed and
Change-Id: I06b99bc77318c03595377614ee75715031a60923
---
M includes/CrossCheck/Comparer/TimeValueComparer.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/CrossCheck/Comparer/TimeValueComparer.php
b/includes/CrossCheck/Comparer/TimeValueComparer.php
index 2ea130c..d5f231c 100644
--- a/includes/CrossCheck/Comparer/TimeValueComparer.php
+++ b/includes/CrossCheck/Comparer/TimeValueComparer.php
@@ -79,7 +79,7 @@
switch ( $precision ) {
case TimeValue::PRECISION_SECOND:
- $result = $result && $diff->s === 0;
+ $result = $diff->s === 0;
// Fall through with no break/return. This is
critical for this algorithm.
case TimeValue::PRECISION_MINUTE:
$result = $result && $diff->i === 0;
--
To view, visit https://gerrit.wikimedia.org/r/243491
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06b99bc77318c03595377614ee75715031a60923
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
