Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/243590
Change subject: Remove return value from
FormSpecialPage::checkExecutePermissions
......................................................................
Remove return value from FormSpecialPage::checkExecutePermissions
It is unused and few callers comply with it
Change-Id: I3ac02ca996b57bf2222006712cc988a064dc38e5
---
M includes/specialpage/FormSpecialPage.php
M includes/specials/SpecialPasswordReset.php
2 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/90/243590/1
diff --git a/includes/specialpage/FormSpecialPage.php
b/includes/specialpage/FormSpecialPage.php
index 42c5980..d22875b 100644
--- a/includes/specialpage/FormSpecialPage.php
+++ b/includes/specialpage/FormSpecialPage.php
@@ -169,7 +169,6 @@
* Failures here must throw subclasses of ErrorPageError.
* @param User $user
* @throws UserBlockedError
- * @return bool True
*/
protected function checkExecutePermissions( User $user ) {
$this->checkPermissions();
@@ -182,8 +181,6 @@
if ( $this->requiresWrite() ) {
$this->checkReadOnly();
}
-
- return true;
}
/**
diff --git a/includes/specials/SpecialPasswordReset.php
b/includes/specials/SpecialPasswordReset.php
index 9e72807..f1eb8c2 100644
--- a/includes/specials/SpecialPasswordReset.php
+++ b/includes/specials/SpecialPasswordReset.php
@@ -58,7 +58,7 @@
throw new ErrorPageError( 'internalerror',
'resetpass_forbidden' );
}
- return parent::checkExecutePermissions( $user );
+ parent::checkExecutePermissions( $user );
}
protected function getFormFields() {
--
To view, visit https://gerrit.wikimedia.org/r/243590
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ac02ca996b57bf2222006712cc988a064dc38e5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
